Review main Merged

94088[BUGFIX] Use unique ID for resource pointer fields in multi-upload field

Elias Häußler CR +2 V +2 Normal +86 −14 updated 06/01/26, 14:11

Commit message

Once a form element of type `FileUpload` is configured with the
`multiple` attribute and more than one file is uploaded, all resulting
resource pointer fields contain the same ID. This patch appends the
current index to the ID to make them unique in the DOM.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1319

  1. Elias Häußler uploaded patch set 1 05/13/26, 10:45

  2. Elias Häußler uploaded patch set 2 05/13/26, 10:46

  3. core-ci voted on patch set 1 V -1 05/13/26, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101961

  4. core-ci voted on patch set 2 V +1 05/13/26, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101962

  5. Josua Vogel uploaded patch set 3 V +1 05/14/26, 08:42

  6. Josua Vogel uploaded patch set 4 05/14/26, 08:42

  7. core-ci voted on patch set 3 V -1 05/14/26, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102023

  8. core-ci voted on patch set 4 V -1 05/14/26, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102024

  9. Josua Vogel commented on patch set 5 V -1 05/14/26, 08:54

    Published edit on patch set 4.
  10. core-ci voted on patch set 5 V +1 05/14/26, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102025

  11. Josua Vogel commented on patch set 5 CR +1 V +1 05/14/26, 09:06

    Thanks for the fix! I took the opportunity to make the old code a little more readable. I hope that's okay with you.
  12. Garvin Hicking commented on patch set 5 05/14/26, 20:50

    I think we should take the opportunity to cover this with a functional test?
  13. Josua Vogel uploaded patch set 6 CR +1 V +1 05/19/26, 05:46

  14. core-ci voted on patch set 6 V +1 05/19/26, 05:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102175

  15. Josua Vogel commented on patch set 6 CR +1 V +1 05/19/26, 06:20

    Reply

    Yes! I took the opportunity and added a test
  16. Garvin Hicking voted on patch set 6 CR +1 V +1 05/19/26, 09:10

  17. Oliver Klee voted on patch set 6 V +1 05/19/26, 11:50

  18. Garvin Hicking voted on patch set 6 CR +2 V +2 06/01/26, 14:11

  19. Garvin Hicking merged patch set 7 06/01/26, 14:11