Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Quiet

94093[FEATURE] Use translation domains for form backend labels

Josua Vogel CR 0 V 0 Nightmare +1617 −1336 updated 10/15/26, 11:03

Commit message

All backend labels of the form configuration shipped with EXT:form now
use the domain-based translation syntax, for example
"form.database:formEditor.elements.Text.label", instead of naked
translation keys resolved through the translationFiles indirection.

TranslationService::translateValuesRecursive() no longer translates
every string value. Translation references (LLL: or domain:key) are
translated directly, other values like file paths, CSS classes and
identifiers are left untouched.

The translationFiles options of formEditor, formEngine, the finisher
FormEngine sections and formManager are deprecated. As long as one of
them is configured, naked keys are still looked up in the configured
files and in Database.xlf of EXT:form as a fallback.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 12
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/93/94093/12 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/93/94093/12 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 62

Show 42 more files

Review log 2134

Show 59 earlier messages
  1. Josua Vogel uploaded patch set 1 05/15/26, 06:42

  2. core-ci voted on patch set 1 V -1 05/15/26, 06:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102043

  3. Josua Vogel uploaded patch set 2 V -1 05/15/26, 07:03

  4. core-ci voted on patch set 2 V +1 05/15/26, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102044

  5. Josua Vogel uploaded patch set 3 V +1 05/29/26, 07:55

  6. core-ci voted on patch set 3 V +1 05/29/26, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102595

  7. Josua Vogel rebased onto patch set 4 V +1 06/11/26, 14:21

  8. core-ci voted on patch set 4 V +1 06/11/26, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103406

  9. Garvin Hicking commented on patch set 4 06/11/26, 17:47

    Please check out https://forge.typo3.org/issues/109983#change-570612 - I wonder if this could hit us here too
  1. Josua Vogel uploaded patch set 5 V +1 06/12/26, 09:37

  2. Josua Vogel commented on patch set 5 06/12/26, 09:40

    Reply

    Yes, I added a test
  3. core-ci voted on patch set 5 V -1 06/12/26, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103438

  4. core-ci commented on patch set 5 06/12/26, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103438

  5. Josua Vogel rebased onto patch set 6 V -1 06/12/26, 10:32

  6. core-ci voted on patch set 6 V +1 06/12/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103442

  7. Josua Vogel commented on patch set 6 06/12/26, 10:42

    Reply

    Bug fixed ;)
  8. Josua Vogel rebased onto patch set 7 V +1 06/19/26, 05:02

  9. core-ci voted on patch set 7 V +1 06/19/26, 05:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103657

  10. Josua Vogel rebased onto patch set 8 V +1 07/17/26, 15:08

  11. core-ci voted on patch set 8 V -1 07/17/26, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104895

  12. Josua Vogel uploaded patch set 9 V -1 07/20/26, 05:57

  13. core-ci voted on patch set 9 V -1 07/20/26, 06:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104999

  14. Josua Vogel uploaded patch set 10 V -1 07/20/26, 06:17

  15. core-ci voted on patch set 10 V +1 07/20/26, 06:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105000

  16. Garvin Hicking commented on patch set 10 CR -1 07/24/26, 15:04

    There are still parts where `translationFiles:` exists (general Form, Finishers) but the changelog to me delivers the expectation that it's gone everywhere. Could you add a hint/note there, which exact translationFiles: keys vanish, and which ones stay? The docs in the `proto/` section also seem to need adaptation for it, as they still list the `translationFiles` options that are removed here. Also maybe it's time to remove the auto-migration from `translationFile` to `translationFiles`?
  17. Garvin Hicking commented on patch set 10 07/24/26, 15:08

    I'm a bit afraid of how much adaptation this could mean for integrators. Maybe we should have some kind of ananylser / migration wizard that at least replaces `label: formEditor` with `label: form.formEditor`? Another thought is maybe to keep translationFiles around, and just remove it in our core files...?
  18. Josua Vogel commented on patch set 10 07/26/26, 12:40

    Reply

    Yeah, you're right. The approach is a bit extreme and involves a lot of work. For the sake of developer happiness, we should probably avoid that. I'll think of a way to support the old method and deprecate the translationFiles as much as possible. That will give everyone a little more time to get the code in order.
  19. Josua Vogel marked it work in progress 07/26/26, 13:08

  20. Josua Vogel uploaded patch set 11 CR -1 V +1 10/12/26, 20:27

  21. core-ci voted on patch set 11 V +1 10/12/26, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110951

  22. Josua Vogel uploaded patch set 12 V +1 10/12/26, 20:38

  23. Josua Vogel commented on patch set 12 10/12/26, 20:43

    This change is ready for review.
  24. core-ci voted on patch set 12 V +1 10/12/26, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110952

  25. Lina Wolf commented on patch set 12 10/15/26, 11:03

    The form manual on main was re-indented in https://review.typo3.org/c/Packages/TYPO3.CMS/+/96702 (two spaces after "..", 4-space levels, headline levels). This change will probably conflict in typo3/sysext/form/Documentation when rebased. The script used for the conversion can help to bring new text into the same format; ask me if you need it.