Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
94093[FEATURE] Use translation domains for form backend labels
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 12
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/93/94093/12 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/93/94093/12 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 62
- typo3/sysext/core/Documentation/Changelog/15.0/Deprecation-109835-FormTranslationFilesInBackendConfiguration.rstnew+94 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-109835-FormTranslationDomainBasedLabels.rstnew+43 −0
- typo3/sysext/form/Classes/Service/TranslationService.php+108 −48
- typo3/sysext/form/Classes/Storage/DatabaseStorageAdapter.php+2 −2
- typo3/sysext/form/Classes/Storage/ExtensionStorageAdapter.php+2 −2
- typo3/sysext/form/Configuration/Form/Base/Finishers/Closure.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Finishers/Confirmation.yaml+4 −4
- typo3/sysext/form/Configuration/Form/Base/Finishers/DeleteUploads.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Finishers/EmailToReceiver.yaml+27 −27
- typo3/sysext/form/Configuration/Form/Base/Finishers/EmailToSender.yaml+27 −27
- typo3/sysext/form/Configuration/Form/Base/Finishers/FlashMessage.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Finishers/Redirect.yaml+5 −5
- typo3/sysext/form/Configuration/Form/Base/Finishers/SaveToDatabase.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/AdvancedPassword.yaml+63 −63
- typo3/sysext/form/Configuration/Form/Base/FormElements/Checkbox.yaml+23 −23
- typo3/sysext/form/Configuration/Form/Base/FormElements/ContentElement.yaml+15 −15
- typo3/sysext/form/Configuration/Form/Base/FormElements/CountrySelect.yaml+29 −29
- typo3/sysext/form/Configuration/Form/Base/FormElements/Date.yaml+59 −59
- typo3/sysext/form/Configuration/Form/Base/FormElements/Email.yaml+56 −56
- typo3/sysext/form/Configuration/Form/Base/FormElements/Fieldset.yaml+13 −13
Show 42 more files
- typo3/sysext/form/Configuration/Form/Base/FormElements/FileUpload.yaml+43 −43
- typo3/sysext/form/Configuration/Form/Base/FormElements/Form.yaml+103 −103
- typo3/sysext/form/Configuration/Form/Base/FormElements/GridColumn.yaml+13 −13
- typo3/sysext/form/Configuration/Form/Base/FormElements/GridRow.yaml+13 −13
- typo3/sysext/form/Configuration/Form/Base/FormElements/Hidden.yaml+17 −17
- typo3/sysext/form/Configuration/Form/Base/FormElements/Honeypot.yaml+57 −57
- typo3/sysext/form/Configuration/Form/Base/FormElements/ImageUpload.yaml+39 −39
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiCheckbox.yaml+34 −34
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiSelect.yaml+36 −36
- typo3/sysext/form/Configuration/Form/Base/FormElements/Number.yaml+61 −61
- typo3/sysext/form/Configuration/Form/Base/FormElements/Page.yaml+7 −7
- typo3/sysext/form/Configuration/Form/Base/FormElements/Password.yaml+62 −62
- typo3/sysext/form/Configuration/Form/Base/FormElements/RadioButton.yaml+29 −29
- typo3/sysext/form/Configuration/Form/Base/FormElements/SingleSelect.yaml+31 −31
- typo3/sysext/form/Configuration/Form/Base/FormElements/StaticText.yaml+14 −14
- typo3/sysext/form/Configuration/Form/Base/FormElements/SummaryPage.yaml+7 −7
- typo3/sysext/form/Configuration/Form/Base/FormElements/Telephone.yaml+60 −60
- typo3/sysext/form/Configuration/Form/Base/FormElements/Text.yaml+80 −80
- typo3/sysext/form/Configuration/Form/Base/FormElements/Textarea.yaml+60 −60
- typo3/sysext/form/Configuration/Form/Base/FormElements/Url.yaml+56 −56
- typo3/sysext/form/Configuration/Form/Base/Validators/Alphanumeric.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/Count.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/DateRange.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/DateTime.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/EmailAddress.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/FileSize.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/Float.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/Integer.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/NotEmpty.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/Number.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/NumberRange.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/RegularExpression.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/StringLength.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/Validators/Text.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/config.yaml+24 −32
- typo3/sysext/form/Documentation/I/Concepts/FormEditor/Index.rst+16 −23
- typo3/sysext/form/Documentation/I/Concepts/FormPlugin/Index.rst+11 −22
- typo3/sysext/form/Documentation/I/Config/formManager/Index.rst+8 −6
- typo3/sysext/form/Documentation/I/Config/proto/formEditor/Index.rst+8 −8
- typo3/sysext/form/Documentation/I/Config/proto/formEngine/Index.rst+8 −8
- typo3/sysext/form/Documentation/I/HowTos/CustomFormElement/_CustomFormSetup.yaml+17 −16
- typo3/sysext/form/Tests/Functional/Service/TranslationServiceTest.php+115 −8
Review log 2134
Show 59 earlier messages
-
Josua Vogel uploaded patch set 1 05/15/26, 06:42
-
core-ci voted on patch set 1 V -1 05/15/26, 06:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102043
-
Josua Vogel uploaded patch set 2
V -105/15/26, 07:03 -
core-ci voted on patch set 2 V +1 05/15/26, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102044
-
Josua Vogel uploaded patch set 3
V +105/29/26, 07:55 -
core-ci voted on patch set 3 V +1 05/29/26, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102595
-
Josua Vogel rebased onto patch set 4
V +106/11/26, 14:21 -
core-ci voted on patch set 4 V +1 06/11/26, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103406
-
Garvin Hicking commented on patch set 4 06/11/26, 17:47
Please check out https://forge.typo3.org/issues/109983#change-570612 - I wonder if this could hit us here too
-
Josua Vogel uploaded patch set 5
V +106/12/26, 09:37 -
Josua Vogel commented on patch set 5 06/12/26, 09:40
Reply
Yes, I added a test -
core-ci voted on patch set 5 V -1 06/12/26, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103438
-
core-ci commented on patch set 5 06/12/26, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103438
-
Josua Vogel rebased onto patch set 6
V -106/12/26, 10:32 -
core-ci voted on patch set 6 V +1 06/12/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103442
-
Josua Vogel commented on patch set 6 06/12/26, 10:42
Reply
Bug fixed ;) -
Josua Vogel rebased onto patch set 7
V +106/19/26, 05:02 -
core-ci voted on patch set 7 V +1 06/19/26, 05:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103657
-
Josua Vogel rebased onto patch set 8
V +107/17/26, 15:08 -
core-ci voted on patch set 8 V -1 07/17/26, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104895
-
Josua Vogel uploaded patch set 9
V -107/20/26, 05:57 -
core-ci voted on patch set 9 V -1 07/20/26, 06:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104999
-
Josua Vogel uploaded patch set 10
V -107/20/26, 06:17 -
core-ci voted on patch set 10 V +1 07/20/26, 06:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105000
-
Garvin Hicking commented on patch set 10 CR -1 07/24/26, 15:04
There are still parts where `translationFiles:` exists (general Form, Finishers) but the changelog to me delivers the expectation that it's gone everywhere. Could you add a hint/note there, which exact translationFiles: keys vanish, and which ones stay? The docs in the `proto/` section also seem to need adaptation for it, as they still list the `translationFiles` options that are removed here. Also maybe it's time to remove the auto-migration from `translationFile` to `translationFiles`? -
Garvin Hicking commented on patch set 10 07/24/26, 15:08
I'm a bit afraid of how much adaptation this could mean for integrators. Maybe we should have some kind of ananylser / migration wizard that at least replaces `label: formEditor` with `label: form.formEditor`? Another thought is maybe to keep translationFiles around, and just remove it in our core files...? -
Josua Vogel commented on patch set 10 07/26/26, 12:40
Reply
Yeah, you're right. The approach is a bit extreme and involves a lot of work. For the sake of developer happiness, we should probably avoid that. I'll think of a way to support the old method and deprecate the translationFiles as much as possible. That will give everyone a little more time to get the code in order. -
Josua Vogel marked it work in progress 07/26/26, 13:08
-
Josua Vogel uploaded patch set 11
CR -1V +110/12/26, 20:27 -
core-ci voted on patch set 11 V +1 10/12/26, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110951
-
Josua Vogel uploaded patch set 12
V +110/12/26, 20:38 -
Josua Vogel commented on patch set 12 10/12/26, 20:43
This change is ready for review. -
core-ci voted on patch set 12 V +1 10/12/26, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110952
-
Lina Wolf commented on patch set 12 10/15/26, 11:03
The form manual on main was re-indented in https://review.typo3.org/c/Packages/TYPO3.CMS/+/96702 (two spaces after "..", 4-space levels, headline levels). This change will probably conflict in typo3/sysext/form/Documentation when rebased. The script used for the conversion can help to bring new text into the same format; ask me if you need it.