94102[BUGFIX] Fix bulk execute action in scheduler deleting tasks
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1622
-
Benni Mack uploaded patch set 1 05/17/26, 13:03
-
core-ci voted on patch set 1 V +1 05/17/26, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102098
-
Benni Mack marked it ready for review 05/18/26, 09:39
-
Georg Ringer voted on patch set 1 CR +1 V +1 05/18/26, 12:06
-
Garvin Hicking commented on patch set 1 05/19/26, 17:29
This applies to main and 14.3, not 13.4 right? -
Garvin Hicking commented on patch set 1 V +1 05/19/26, 17:38
Seems to work - however, what's the multi-"delete" really for, I don't seem to have a multi-delete button, I only get "multi-execute"?! So I wonder, should we name this "delete" better "execute"? :-D -
Benni Mack commented on patch set 1 05/23/26, 21:46
Reply
this is getting nasty then (at least in this patch), or did I get your comment wrong? -
Garvin Hicking commented on patch set 1 05/24/26, 08:34
Reply
If renaming this can get nasty (didnt check the nastylesslevels) then maybe a comment in the two places could help to indicate "this does not delete, it executes. @todo rename this at some poin". -
Garvin Hicking commented on patch set 1 CR +1 07/02/26, 11:45
I'm at peace here even though I would appreciate a docblock ;) -
Garvin Hicking commented on patch set 1 07/02/26, 11:45
Reply
Done -
Benni Mack updated the commit message in patch set 2
CR +1V +107/02/26, 11:48 -
Benni Mack commented on patch set 2 07/02/26, 11:48
Reply
Done -
core-ci voted on patch set 2 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104233
-
core-ci commented on patch set 2 07/02/26, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104233
-
core-ci commented on patch set 2 07/02/26, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104233
-
Benni Mack rebased onto patch set 3
V -107/02/26, 15:19 -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 07/02/26, 15:22
-
core-ci voted on patch set 2 V +1 07/02/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104233
-
core-ci voted on patch set 3 V +1 07/02/26, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104238
-
Garvin Hicking voted on patch set 3 CR +1 V +1 07/02/26, 15:45
-
Benni Mack voted on patch set 3 CR +2 V +2 07/02/26, 21:45
-
Benni Mack merged patch set 4 07/02/26, 21:45