Review main Merged

94102[BUGFIX] Fix bulk execute action in scheduler deleting tasks

Benni Mack CR +2 V +2 Easy +17 −9 updated 07/02/26, 21:45

Commit message

Clicking the "Execute selected" button in the scheduler task list
caused one of the selected tasks to be deleted instead of executed.

Two issues combined to produce this:

1. The multi-record-selection action in scheduler.ts appended hidden
   inputs named "execute" and "scheduleCron" to the form, but the
   controller checks parsedBody['action']['execute'] and
   parsedBody['action']['scheduleCron']. The mismatch meant neither
   bulk-action branch was ever entered.

2. The per-task delete/stop mini-forms were nested inside the outer
   multi-record-selection <form>. HTML does not support nested forms;
   browsers ignore the inner <form> tags, making all their hidden
   action[delete] / action[stop] inputs belong to the outer form.
   When the outer form was submitted programmatically for bulk execute,
   those inputs were included, and the controller's elseif chain
   matched the delete branch instead.

Fix: rename the appended inputs to action[execute] and
action[scheduleCron], and move the per-task delete/stop mini-forms
to before the outer multi-record-selection form so they cannot
pollute its submission.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1622

  1. Benni Mack uploaded patch set 1 05/17/26, 13:03

  2. core-ci voted on patch set 1 V +1 05/17/26, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102098

  3. Benni Mack marked it ready for review 05/18/26, 09:39

  4. Georg Ringer voted on patch set 1 CR +1 V +1 05/18/26, 12:06

  5. Garvin Hicking commented on patch set 1 05/19/26, 17:29

    This applies to main and 14.3, not 13.4 right?
  6. Garvin Hicking commented on patch set 1 V +1 05/19/26, 17:38

    Seems to work - however, what's the multi-"delete" really for, I don't seem to have a multi-delete button, I only get "multi-execute"?! So I wonder, should we name this "delete" better "execute"? :-D
  7. Benni Mack commented on patch set 1 05/23/26, 21:46

    Reply

    this is getting nasty then (at least in this patch), or did I get your comment wrong?
  8. Garvin Hicking commented on patch set 1 05/24/26, 08:34

    Reply

    If renaming this can get nasty (didnt check the nastylesslevels) then maybe a comment in the two places could help to indicate "this does not delete, it executes. @todo rename this at some poin".
  9. Garvin Hicking commented on patch set 1 CR +1 07/02/26, 11:45

    I'm at peace here even though I would appreciate a docblock ;)
  10. Garvin Hicking commented on patch set 1 07/02/26, 11:45

    Reply

    Done
  11. Benni Mack updated the commit message in patch set 2 CR +1 V +1 07/02/26, 11:48

  12. Benni Mack commented on patch set 2 07/02/26, 11:48

    Reply

    Done
  13. core-ci voted on patch set 2 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104233

  14. core-ci commented on patch set 2 07/02/26, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104233

  15. core-ci commented on patch set 2 07/02/26, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104233

  16. Benni Mack rebased onto patch set 3 V -1 07/02/26, 15:19

  17. Simon Schaufelberger voted on patch set 3 CR +1 V +1 07/02/26, 15:22

  18. core-ci voted on patch set 2 V +1 07/02/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104233

  19. core-ci voted on patch set 3 V +1 07/02/26, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104238

  20. Garvin Hicking voted on patch set 3 CR +1 V +1 07/02/26, 15:45

  21. Benni Mack voted on patch set 3 CR +2 V +2 07/02/26, 21:45

  22. Benni Mack merged patch set 4 07/02/26, 21:45