Review main Merged

94106[FEATURE] Allow TCA eval "lower" for type email

Benoit Chenu CR +2 V +2 Hard +259 −1 updated 09/30/26, 06:28

Commit message

TCA fields with type=email evaluated the keywords "unique" and
"uniqueInPid" only, so email addresses could not be stored in a
normalized lowercase form.

DataHandler now evaluates the keyword "lower" for type=email as
well. It is applied before the uniqueness checks, so two addresses
that differ in casing only are recognized as the same value, and
it is not tied to the presence of a field name, which makes it
work for FlexForm fields, too.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1015

  1. Benoit Chenu uploaded patch set 1 05/18/26, 12:29

  2. Mathias Brodala commented on patch set 1 CR -1 05/18/26, 12:38

    Strictly speaking the local part of an email address ("foo" in "foo@example.org") is case-sensitive but ESP usually normalize this to lowercase to avoid confusion. In any case a feature must be accompanied with an RST: https://docs.typo3.org/permalink/t3contribute:documenting-changelog-features Also we should at least have some basic tests for this.
  3. core-ci voted on patch set 1 V +1 05/18/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102140

  4. Georg Ringer uploaded patch set 2 CR -1 V +1 09/09/26, 14:52

  5. Georg Ringer uploaded patch set 3 09/09/26, 14:58

  6. core-ci voted on patch set 2 V +1 09/09/26, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108196

  7. Georg Ringer uploaded patch set 4 09/09/26, 15:02

  8. core-ci voted on patch set 3 V +1 09/09/26, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108197

  9. core-ci voted on patch set 4 V +1 09/09/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108198

  10. Georg Ringer uploaded patch set 5 V +1 09/29/26, 19:51

  11. core-ci voted on patch set 5 V +1 09/29/26, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109540

  12. Benni Mack commented on patch set 5 09/30/26, 06:24

    Reply

    all done.
  13. Benni Mack voted on patch set 5 CR +1 V +1 09/30/26, 06:24

  14. Georg Ringer voted on patch set 5 CR +2 V +2 09/30/26, 06:28

  15. Georg Ringer merged patch set 6 09/30/26, 06:28