94112[TASK] Raise `phpstan/phpstan`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 4
Review log 811
-
Markus Klein uploaded patch set 1 05/19/26, 07:07
-
core-ci voted on patch set 1 V -1 05/19/26, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102192
-
Markus Klein uploaded patch set 2
V -105/19/26, 07:44 -
core-ci voted on patch set 2 V +1 05/19/26, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102195
-
Garvin Hicking commented on patch set 2 05/19/26, 08:58
Thanks! (needs an issue, PHPStan raise, updated baseline, backports - couldn't verify the code fix myself yet, won't have time for this today) -
Stefan Bürk uploaded patch set 3
V +105/19/26, 13:15 -
Stefan Bürk commented on patch set 3 05/19/26, 13:22
Reply
DoneRouteSorter.php:139That's okay - only possible left constellation. -
core-ci voted on patch set 3 V +1 05/19/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102215
-
Garvin Hicking voted on patch set 3 CR +1 V +1 05/19/26, 13:27
-
Stefan Bürk voted on patch set 3 CR +2 V +2 05/19/26, 13:33
-
Stefan Bürk merged patch set 4 05/19/26, 13:38