Review main Merged

94112[TASK] Raise `phpstan/phpstan`

Markus Klein CR +2 V +2 Easy +7 −13 updated 05/19/26, 13:38

Commit message

Static code analyzer PHPStan is raised allowing
to remove one previously reported error pattern.

The newly detected one is mitigated by adjusting
the code place instead of adding it to the base
line.

Used command(s):

> Build/Scripts/runTests.sh -s composer -- require \
    --dev 'phpstan/phpstan':'^2.1.55'
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 811

  1. Markus Klein uploaded patch set 1 05/19/26, 07:07

  2. core-ci voted on patch set 1 V -1 05/19/26, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102192

  3. Markus Klein uploaded patch set 2 V -1 05/19/26, 07:44

  4. core-ci voted on patch set 2 V +1 05/19/26, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102195

  5. Garvin Hicking commented on patch set 2 05/19/26, 08:58

    Thanks! (needs an issue, PHPStan raise, updated baseline, backports - couldn't verify the code fix myself yet, won't have time for this today)
  6. Stefan Bürk uploaded patch set 3 V +1 05/19/26, 13:15

  7. Stefan Bürk commented on patch set 3 05/19/26, 13:22

    Reply

    Done

    RouteSorter.php:139

    That's okay - only possible left constellation.
  8. core-ci voted on patch set 3 V +1 05/19/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102215

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 05/19/26, 13:27

  10. Stefan Bürk voted on patch set 3 CR +2 V +2 05/19/26, 13:33

  11. Stefan Bürk merged patch set 4 05/19/26, 13:38