94113[TASK] Upgrade to CKEditor 5 v48
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 147
- Build/overrides/ckeditor5/src/clipboard.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/core.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/engine.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/enter.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/paragraph.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/select-all.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/typing.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/ui.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/undo.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/utils.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/watchdog.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/src/widget.d.tsdeleted+0 −1
- Build/overrides/ckeditor5/package.jsondeleted+0 −7
- Build/patches/@ckeditor+ckeditor5-utils+48.5.1.patchnew+51 −0
- Build/rollup/ckeditor/translations.js+67 −134
- Build/rollup/ckeditor.js+60 −35
- Build/Sources/JavaScript/rte_ckeditor/contrib/ckeditor5-link.jsdeleted+0 −2
- Build/Sources/Sass/ckeditor5.scssnew+34 −0
- Build/Sources/TypeScript/rte-ckeditor/plugin/typo3-link.ts+7 −9
- Build/Sources/TypeScript/rte-ckeditor/rte-link-browser.ts+1 −1
Show 127 more files
- Build/types/ckeditor5-bundle/index.d.ts+0 −5
- Build/Gruntfile.js+4 −0
- Build/package-lock.json+2551 −2741
- Build/package.json7+5 −42
- Build/web-test-runner.config.mjs+0 −1
- typo3/sysext/rte_ckeditor/Configuration/JavaScriptModules.php+0 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-alignment.js+9 −6
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-autoformat.js+7 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-basic-styles.js+27 −24
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-block-quote.js+8 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-clipboard.js+21 −18
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-code-block.js+15 −12
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-core.js+31 −16
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-classic.js+7 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-decoupled.js+7 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-multi-root.js+7 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-engine.js+130 −124
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-enter.js+10 −7
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-essentials.js+4 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-find-and-replace.js+17 −14
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-font.js+26 −23
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-fullscreen.js+18 −12
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-heading.js+11 −8
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-highlight.js+8 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-horizontal-line.js+8 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-html-support.js+29 −26
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-icons.js+14 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-image.js+59 −59
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-indent.js+20 −11
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-inspector.js+26 −27
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-language.js+9 −6
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-link.js+22 −19
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-list.js+57 −54
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-mention.js+11 −8
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-paragraph.js+8 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-paste-from-office.js+24 −21
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-remove-format.js+8 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-select-all.js+8 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-show-blocks.js+10 −7
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-source-editing.js+5 −2
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-special-characters.js+15 −12
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-style.js+16 −13
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-table.js+101 −92
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-theme-lark.jsdeleted+0 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-typing.js+18 −15
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-ui.js+110 −107
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-undo.js+10 −7
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-upload.js+8 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-utils.js+85 −79
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-watchdog.js+15 −9
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-widget.js+15 −12
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-word-count.js+8 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/af.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ar.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ast.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/az.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/be.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/bg.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/bn.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/bs.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ca.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/cs.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/da.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/de-ch.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/de.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/el.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en-au.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en-gb.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/eo.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/es-co.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/es.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/et.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/eu.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/fa.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/fi.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/fr.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/gl.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/gu.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/he.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hi.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hr.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hu.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hy.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/id.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/it.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ja.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/jv.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/kk.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/km.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/kn.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ko.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ku.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/lt.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/lv.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ms.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/nb.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ne.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/nl.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/no.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/oc.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/pl.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/pt-br.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/pt.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ro.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ru.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/si.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sk.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sl.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sq.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sr-latn.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sr.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sv.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/th.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ti.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/tk.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/tr.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/tt.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ug.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/uk.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ur.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/uz.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/vi.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/zh-cn.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/zh.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Css/editor.css+1483 −32
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/typo3-link.js+1 −1
Review log 2740
Show 915 earlier messages
-
Benjamin Franzke uploaded patch set 1 05/19/26, 10:49
-
core-ci voted on patch set 1 V -1 05/19/26, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102209
-
Benjamin Franzke uploaded patch set 2
V -105/19/26, 14:15 -
core-ci voted on patch set 2 V -1 05/19/26, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102230
-
Benjamin Franzke commented on patch set 2 05/19/26, 14:32
Translations no longer ship as `.po` files, but as `.js` => rollup/ckeditor/translations.js needs to be adapted -
Ondřej Chrastina uploaded patch set 3
V -108/08/26, 08:57 -
core-ci voted on patch set 3 V +1 08/08/26, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106164
-
Benjamin Franzke uploaded patch set 4
V +108/25/26, 19:10 -
core-ci voted on patch set 4 V +1 08/25/26, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107095
-
Andreas Kienast commented on patch set 4 08/26/26, 05:40
package.json:73Terser was removed by you with https://review.typo3.org/c/Packages/TYPO3.CMS/+/88272 not that long ago, do we really have to introduce it again? -
Benjamin Franzke uploaded patch set 5
V +108/26/26, 07:16 -
Benjamin Franzke commented on patch set 5 08/26/26, 07:16
Reply
Fixed by Ondřej Chrastina in patchset 3, thanks!package.json:73Replyack, I don't know at all, makes no sense at all to keep it (it was pulled in by `terser-webpack-plugin` previously and it seems I wanted to keep it without thinking about it). Remove, thanks! -
core-ci voted on patch set 5 V -1 08/26/26, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107120
-
Benjamin Franzke uploaded patch set 6
V -108/26/26, 07:33 -
core-ci voted on patch set 6 V +1 08/26/26, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107124
-
Benjamin Franzke uploaded patch set 7
V +108/26/26, 11:51 -
Benjamin Franzke commented on patch set 7 08/26/26, 11:52
package.json:73Replyah, now I know again: Otherwise htmlnano errors with: > You have to install "terser" in order to use htmlnano's "minifyJs" module -
Andreas Kienast commented on patch set 7 08/26/26, 11:53
package.json:90Indentation is broken -
Benjamin Franzke uploaded patch set 8 08/26/26, 11:54
-
Benjamin Franzke commented on patch set 8 08/26/26, 11:55
package.json:90ReplyThanks! Fixed -
Benjamin Franzke commented on patch set 8 08/26/26, 11:56
@ckeditor+ckeditor5-utils+48.4.0.patch:9I'll try to create an upstream issue to get this fixed upstream instead. if not, Benji is trying to enable strict types in our codebase, that means by then the patch can be removed. -
core-ci voted on patch set 7 V -1 08/26/26, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107134
-
core-ci voted on patch set 8 V -1 08/26/26, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107135
-
Benjamin Franzke uploaded patch set 9
V -108/26/26, 13:58 -
core-ci voted on patch set 9 V +1 08/26/26, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107153
-
Benjamin Franzke rebased onto patch set 10
V +109/02/26, 21:10 -
core-ci voted on patch set 10 V +1 09/02/26, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107681
-
Benjamin Franzke commented on patch set 10 CR -1 09/03/26, 06:59
package.json:12348.5.0 has been released yesterday: https://github.com/ckeditor/ckeditor5/releases/tag/v48.5.0 -
Benjamin Franzke uploaded patch set 11
CR -1V +109/15/26, 13:19 -
Benjamin Franzke commented on patch set 11 09/15/26, 13:19
package.json:123ReplyDone -
core-ci voted on patch set 11 V +1 09/15/26, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108622
-
Benjamin Franzke uploaded patch set 12
V +109/16/26, 05:55 -
core-ci voted on patch set 12 V +1 09/16/26, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108658
-
Benjamin Franzke updated the commit message in patch set 13
V +109/16/26, 06:33 -
core-ci voted on patch set 13 V +1 09/16/26, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108660
-
Benjamin Franzke commented on patch set 13 09/16/26, 06:49
@ckeditor+ckeditor5-utils+48.4.0.patch:9Reply -
Garvin Hicking commented on patch set 13 CR +1 V +1 09/16/26, 07:15
Tested a few things in safari/ff/chromium macos, works for me -
Benni Mack commented on patch set 13 CR +1 V +1 09/16/26, 08:42
same for me (but didn't have custom plugins) -
Benjamin Franzke voted on patch set 13 CR +2 V +2 09/16/26, 09:28
-
Benjamin Franzke merged patch set 14 09/16/26, 10:05