Review main Merged

94113[TASK] Upgrade to CKEditor 5 v48

Benjamin Franzke CR +2 V +2 Nightmare +5419 −4009 updated 09/16/26, 10:05

Commit message

CKEditor5 v48 removed most parts of customized builds, which means
that we can no longer opt-out from installing the umbrella package,
since CSS is now shipped in that package. We therefore follow
upstreams recommendation do pull in all packages via `ckeditor5`.

We still build individual modules though, in order to let
integrators decide which plugins to load.

Used commands:

  cd Build
  git rm -rf overrides/ckeditor5
  # removing all individual packages as suggested by
  # https://ckeditor.com/docs/ckeditor5/latest/updating/nim-migration/customized-builds.html#migration-steps
  npm remove \
    @ckeditor/ckeditor5-alignment \
    @ckeditor/ckeditor5-autoformat \
    @ckeditor/ckeditor5-basic-styles \
    @ckeditor/ckeditor5-block-quote \
    @ckeditor/ckeditor5-clipboard \
    @ckeditor/ckeditor5-code-block \
    @ckeditor/ckeditor5-core \
    @ckeditor/ckeditor5-editor-classic \
    @ckeditor/ckeditor5-engine \
    @ckeditor/ckeditor5-essentials \
    @ckeditor/ckeditor5-find-and-replace \
    @ckeditor/ckeditor5-font \
    @ckeditor/ckeditor5-fullscreen \
    @ckeditor/ckeditor5-heading \
    @ckeditor/ckeditor5-highlight \
    @ckeditor/ckeditor5-horizontal-line \
    @ckeditor/ckeditor5-html-support \
    @ckeditor/ckeditor5-icons \
    @ckeditor/ckeditor5-indent \
    @ckeditor/ckeditor5-inspector \
    @ckeditor/ckeditor5-language \
    @ckeditor/ckeditor5-link \
    @ckeditor/ckeditor5-list \
    @ckeditor/ckeditor5-mention \
    @ckeditor/ckeditor5-paragraph \
    @ckeditor/ckeditor5-paste-from-office \
    @ckeditor/ckeditor5-remove-format \
    @ckeditor/ckeditor5-select-all \
    @ckeditor/ckeditor5-show-blocks \
    @ckeditor/ckeditor5-source-editing \
    @ckeditor/ckeditor5-special-characters \
    @ckeditor/ckeditor5-style \
    @ckeditor/ckeditor5-table \
    @ckeditor/ckeditor5-theme-lark \
    @ckeditor/ckeditor5-ui \
    @ckeditor/ckeditor5-undo \
    @ckeditor/ckeditor5-upload \
    @ckeditor/ckeditor5-utils \
    @ckeditor/ckeditor5-watchdog \
    @ckeditor/ckeditor5-word-count
  npm install --save-dev patch-package
  # Required because CKEditor v48 is currently not compatible
  # with tsconfig option `strictNullChecks: false`
  npm install --save ckeditor5@^48.5.1
  npm install --save @ckeditor/ckeditor5-inspector@^5
  # Needed to use htmlnano's "minifyJs" module
  npm install --save-dev terser
  npm remove @ckeditor/ckeditor5-dev-utils
  npm run build

See:

 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.0.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.0.1
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.1.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.1.1
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.2.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.3.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.4.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.5.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.5.1

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 147

Show 127 more files

Review log 2740

Show 915 earlier messages
  1. Benjamin Franzke uploaded patch set 1 05/19/26, 10:49

  2. core-ci voted on patch set 1 V -1 05/19/26, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102209

  3. Benjamin Franzke uploaded patch set 2 V -1 05/19/26, 14:15

  4. core-ci voted on patch set 2 V -1 05/19/26, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102230

  5. Benjamin Franzke commented on patch set 2 05/19/26, 14:32

    Translations no longer ship as `.po` files, but as `.js` => rollup/ckeditor/translations.js needs to be adapted
  6. Ondřej Chrastina uploaded patch set 3 V -1 08/08/26, 08:57

  7. core-ci voted on patch set 3 V +1 08/08/26, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106164

  8. Benjamin Franzke uploaded patch set 4 V +1 08/25/26, 19:10

  9. core-ci voted on patch set 4 V +1 08/25/26, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107095

  10. Andreas Kienast commented on patch set 4 08/26/26, 05:40

    package.json:73

    Terser was removed by you with https://review.typo3.org/c/Packages/TYPO3.CMS/+/88272 not that long ago, do we really have to introduce it again?
  11. Benjamin Franzke uploaded patch set 5 V +1 08/26/26, 07:16

  12. Benjamin Franzke commented on patch set 5 08/26/26, 07:16

    Reply

    Fixed by Ondřej Chrastina in patchset 3, thanks!

    package.json:73 Reply

    ack, I don't know at all, makes no sense at all to keep it (it was pulled in by `terser-webpack-plugin` previously and it seems I wanted to keep it without thinking about it). Remove, thanks!
  13. core-ci voted on patch set 5 V -1 08/26/26, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107120

  14. Benjamin Franzke uploaded patch set 6 V -1 08/26/26, 07:33

  15. core-ci voted on patch set 6 V +1 08/26/26, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107124

  1. Benjamin Franzke uploaded patch set 7 V +1 08/26/26, 11:51

  2. Benjamin Franzke commented on patch set 7 08/26/26, 11:52

    package.json:73 Reply

    ah, now I know again: Otherwise htmlnano errors with: > You have to install "terser" in order to use htmlnano's "minifyJs" module
  3. Andreas Kienast commented on patch set 7 08/26/26, 11:53

    package.json:90

    Indentation is broken
  4. Benjamin Franzke uploaded patch set 8 08/26/26, 11:54

  5. Benjamin Franzke commented on patch set 8 08/26/26, 11:55

    package.json:90 Reply

    Thanks! Fixed
  6. Benjamin Franzke commented on patch set 8 08/26/26, 11:56

    @ckeditor+ckeditor5-utils+48.4.0.patch:9

    I'll try to create an upstream issue to get this fixed upstream instead. if not, Benji is trying to enable strict types in our codebase, that means by then the patch can be removed.
  7. core-ci voted on patch set 7 V -1 08/26/26, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107134

  8. core-ci voted on patch set 8 V -1 08/26/26, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107135

  9. Benjamin Franzke uploaded patch set 9 V -1 08/26/26, 13:58

  10. core-ci voted on patch set 9 V +1 08/26/26, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107153

  11. Benjamin Franzke rebased onto patch set 10 V +1 09/02/26, 21:10

  12. core-ci voted on patch set 10 V +1 09/02/26, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107681

  13. Benjamin Franzke commented on patch set 10 CR -1 09/03/26, 06:59

    package.json:123

  14. Benjamin Franzke uploaded patch set 11 CR -1 V +1 09/15/26, 13:19

  15. Benjamin Franzke commented on patch set 11 09/15/26, 13:19

    package.json:123 Reply

    Done
  16. core-ci voted on patch set 11 V +1 09/15/26, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108622

  17. Benjamin Franzke uploaded patch set 12 V +1 09/16/26, 05:55

  18. core-ci voted on patch set 12 V +1 09/16/26, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108658

  19. Benjamin Franzke updated the commit message in patch set 13 V +1 09/16/26, 06:33

  20. core-ci voted on patch set 13 V +1 09/16/26, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108660

  21. Benjamin Franzke commented on patch set 13 09/16/26, 06:49

    @ckeditor+ckeditor5-utils+48.4.0.patch:9 Reply

  22. Garvin Hicking commented on patch set 13 CR +1 V +1 09/16/26, 07:15

    Tested a few things in safari/ff/chromium macos, works for me
  23. Benni Mack commented on patch set 13 CR +1 V +1 09/16/26, 08:42

    same for me (but didn't have custom plugins)
  24. Benjamin Franzke voted on patch set 13 CR +2 V +2 09/16/26, 09:28

  25. Benjamin Franzke merged patch set 14 09/16/26, 10:05