Review main Merged

94115[BUGFIX] Return focus to edit icon after page title editing

Christian Jung CR +2 V +2 Easy +7 −3 updated 07/05/26, 17:56

Commit message

In the “Page,List” module (in v14: layout and record module),
the page title can be edited inline via the pencil icon next
to the page heading.

Ensure that the interface is not losing visible keyboard focus
after finishing the edit (save or cancel) by returning
the focus to triggering pencil icon.
This improve keyboard operation and positively affects accessibility.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Christian Jung uploaded patch set 1 05/19/26, 12:42

  2. core-ci voted on patch set 1 V +1 05/19/26, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102211

  3. Jennifer Geiß voted on patch set 1 V +1 06/12/26, 05:51

  4. Jennifer Geiß voted on patch set 1 CR +1 06/12/26, 05:52

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 06/23/26, 14:08

  6. Gianluigi Martino uploaded patch set 2 CR +1 V +1 07/03/26, 13:55

  7. Gianluigi Martino commented on patch set 2 07/03/26, 14:01

    Unresolved

    While testing this fix, we noticed that when opening the edit field via the pencil icon, the caret was placed at the very beginning of the title (position 0) instead of at the end requiring an extra keypress before you could continue typing. Patch Set 2 sets the caret to the end of the current value in startEditing(), so focusing the input now positions the cursor after the last characte.
  8. core-ci voted on patch set 2 V +1 07/03/26, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104296

  9. Georg Ringer voted on patch set 2 CR +2 V +2 07/05/26, 17:55

  10. Georg Ringer merged patch set 3 07/05/26, 17:56