Review 14.3 Merged

94118[TASK] Raise `phpstan/phpstan`

Stefan Bürk CR +2 V +2 Easy +7 −13 updated 05/19/26, 13:40

Commit message

Static code analyzer PHPStan is raised allowing
to remove one previously reported error pattern.

The newly detected one is mitigated by adjusting
the code place instead of adding it to the base
line.

Used command(s):

> Build/Scripts/runTests.sh -s composer -- require \
    --dev 'phpstan/phpstan':'^2.1.55'
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Stefan Bürk uploaded patch set 1 05/19/26, 13:23

  2. core-ci voted on patch set 1 V +1 05/19/26, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102219

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 05/19/26, 13:37

  4. Stefan Bürk merged patch set 2 05/19/26, 13:40