Review main Merged

94122[TASK] Remove method exportConfiguration from PageDoktypeRegistry

Nikita Hovratov CR +2 V +2 Normal +18 −35 updated 05/30/26, 15:44

Commit message

After lots of refactoring in the pages registration area and cleanup
of deprecated code, the internal method `exportConfiguration` does not
serve any meaningful purpose anymore. The relevant logic has been
extracted into `getAllowedTypesForDoktype` and the only other consumer
PageDoktypeProvider is adjusted, to use the other API methods. This has
the added benefit that all allowed types are now listed in the
configuration overview page, especially the fallback types, if none
have been explicitly defined.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 813

  1. Nikita Hovratov uploaded patch set 1 05/20/26, 09:07

  2. Nikita Hovratov updated the commit message in patch set 2 05/20/26, 09:09

  3. Nikita Hovratov uploaded patch set 3 05/20/26, 09:14

  4. core-ci voted on patch set 1 V -1 05/20/26, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102270

  5. core-ci voted on patch set 2 V -1 05/20/26, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102271

  6. core-ci voted on patch set 3 V -1 05/20/26, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102272

  7. Nikita Hovratov uploaded patch set 4 V -1 05/20/26, 10:22

  8. core-ci voted on patch set 4 V +1 05/20/26, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102277

  9. Oliver Klee updated the commit message in patch set 5 V +1 05/30/26, 14:36

  10. core-ci voted on patch set 5 V +1 05/30/26, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102682

  11. Christian Kuhn voted on patch set 5 CR +1 V +1 05/30/26, 15:22

  12. Stefan Bürk voted on patch set 5 CR +2 V +2 05/30/26, 15:44

  13. Stefan Bürk merged patch set 6 05/30/26, 15:44