Review main Merged

94123[BUGFIX] Fix string splitting and event binding for constant editor type "wrap"

Stefan Froemken CR +2 V +2 Easy +13 −17 updated 06/05/26, 20:56

Commit message

The Backend Extension Settings module renders two input fields for the
constant editor type "wrap" to split a configuration string by a pipe
character.

Two issues were fixed:

1. A copy-paste error caused the prefix value (index 0) to be assigned
   to both input fields, while the suffix value (index 1) was completely
   ignored. The second input field now correctly receives the suffix part
   of the split value.

2. The keyup event listeners for both "wrap" and "offset" fields were
   registered immediately after appending the custom LitElement to the
   DOM. Since LitElement renders asynchronously, the inner input fields
   did not yet exist at that point, resulting in no listeners being
   attached and changes not being written back to the hidden field.
   The fix replaces bindTo() on individual (not-yet-existing) inputs
   with delegateTo() on the parent element, so events are caught
   regardless of when the child inputs are rendered.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1216

  1. Stefan Froemken uploaded patch set 1 05/20/26, 10:07

  2. core-ci voted on patch set 1 V -1 05/20/26, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102275

  3. Stefan Froemken uploaded patch set 2 V -1 05/20/26, 10:23

  4. core-ci voted on patch set 2 V +1 05/20/26, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102278

  5. Georg Ringer voted on patch set 2 CR +1 V +1 05/20/26, 17:25

  6. Josua Vogel voted on patch set 2 CR +1 V +1 05/20/26, 20:16

  7. Christian Kuhn commented on patch set 2 06/04/26, 22:59

    wrap-group.ts:24

    should imho be ?.trim() - similar to what is done in offset-group.ts
  8. Christian Kuhn uploaded patch set 3 CR +1 V +1 06/04/26, 23:14

  9. Christian Kuhn commented on patch set 3 V -1 06/04/26, 23:16

    funnily, i'm unable to store updated values with styleguide text.wrap_1 [wrap] - neither with, nor without patch, although the fix itself looks good to me. anyone an idea?
  10. core-ci voted on patch set 3 V +1 06/04/26, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102989

  11. Josua Vogel commented on patch set 3 06/05/26, 12:48

    Reply

    on it ...
  12. Josua Vogel uploaded patch set 4 V +1 06/05/26, 12:52

  13. Josua Vogel commented on patch set 4 CR +1 V +1 06/05/26, 12:52

    Reply

    Done
  14. core-ci voted on patch set 4 V +1 06/05/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103033

  15. Christian Kuhn voted on patch set 4 CR +2 V +2 06/05/26, 20:38

  16. Christian Kuhn merged patch set 5 06/05/26, 20:56