Review 13.4 Merged

94126[TASK] Include current site in cache tag collection

Georg Ringer CR +2 V +2 Easy +1 −0 updated 05/28/26, 10:36

Commit message

Adding the resolved site to the cache tags of the request
allows for simply flushing of cache on a "per site basis"

$this->cache->flushByTag("site_<siteIdentifier>")

Valuable for cleaning cache after changing
for ex. a site configuration.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Georg Ringer commented on patch set 1 05/20/26, 19:54

    Cherry Picked from branch 14.3. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Http/RequestHandler.php
  2. Georg Ringer uploaded patch set 2 05/20/26, 19:59

  3. Georg Ringer uploaded patch set 3 05/20/26, 20:01

  4. core-ci voted on patch set 2 V -1 05/20/26, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102291

  5. core-ci voted on patch set 1 V -1 05/20/26, 20:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102290

  6. core-ci voted on patch set 3 V +1 05/20/26, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102292

  7. Georg Ringer commented on patch set 3 CR +2 V +2 05/20/26, 20:18

    This change is ready for review.
  8. Georg Ringer merged patch set 4 05/20/26, 20:18

  9. Benjamin Franzke wrote 05/28/26, 10:36

    Created a revert of this change as Ie01dc5dbfc81ef3b1f399fb17d53064abaf31d6d