Review main Merged

94132[BUGFIX] Restore native submit for modal forms

Wolfgang Klinger CR +2 V +2 Hard +187 −69 updated 10/05/26, 07:43

Commit message

The login refresh modal no longer submitted when pressing Enter in
the password field. After the migration to @typo3/backend/modal the
footer button was not associated with the form anymore. Without a
submit button, implicit submission is blocked as soon as a form has
more than one text-like field, which is the case here.

Bind the footer button to the form again and drop its trigger: The
trigger performed a session refresh request in parallel to the
login and closed the modal regardless of the result, so a wrong
password left the user without a dialog to retry in.

Let the modal focus a field marked as autofocus instead of the
active footer button, also for content loaded via AJAX, and align
the remaining backend modal forms to form-owned submit buttons
instead of manual requestSubmit() and submit() callbacks, so Enter
key submission and native validation behave consistently. As a
result, Enter in the column selector filter now applies the
selection, and Enter in the record download settings now closes
the modal.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 25

Show 5 more files

Review log 1014

  1. Wolfgang Klinger uploaded patch set 1 05/23/26, 04:40

  2. core-ci voted on patch set 1 V +1 05/23/26, 04:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102368

  3. Wolfgang Klinger uploaded patch set 2 V +1 09/28/26, 05:45

  4. core-ci voted on patch set 2 V +1 09/28/26, 05:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109393

  5. Oli Bartsch uploaded patch set 3 V +1 09/30/26, 20:42

  6. core-ci voted on patch set 3 V +1 09/30/26, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109706

  7. Oli Bartsch voted on patch set 3 CR +1 V +1 09/30/26, 20:53

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/02/26, 22:23

  9. Oli Bartsch updated the commit message in patch set 4 CR +1 V +1 10/03/26, 10:47

  10. Oli Bartsch voted on patch set 4 CR +1 V +1 10/03/26, 10:47

  11. core-ci voted on patch set 4 V +1 10/03/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110034

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/05/26, 07:34

  13. Oli Bartsch voted on patch set 4 CR +2 V +2 10/05/26, 07:43

  14. Oli Bartsch merged patch set 5 10/05/26, 07:43