Review main Merged Breaking

94134[!!!][TASK] Remove usage of #[IgnoreValidation] and #[Validate] attributes at method level

Torben Hansen CR +2 V +2 Normal +9 −170 updated 05/25/26, 18:34

Commit message

This change removes the deprecated usage of
:php:`#[IgnoreValidation]` and :php:`#[Validate]`
attributes for parameters at method level in extbase.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 9

Review log 1417

  1. Torben Hansen uploaded patch set 1 05/25/26, 06:09

  2. core-ci voted on patch set 1 V +1 05/25/26, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102398

  3. Oliver Klee voted on patch set 1 CR +1 V +1 05/25/26, 07:13

  4. Garvin Hicking commented on patch set 1 05/25/26, 12:04

    Breaking-109869-RemovedMethodLevelSupportForIgnoreValidationAndValidateAttributes.rst:6

    Can you add an entry to the generic "breaking functionality removed" changelog file? I thini we might not need a dedicated one if we refer to the deprecation entry, wdyt?
  5. Torben Hansen commented on patch set 1 05/25/26, 12:06

    Breaking-109869-RemovedMethodLevelSupportForIgnoreValidationAndValidateAttributes.rst:6 Reply

    I tried to find a suitable match for the deprecation in the general RST file but could not find a fitting match. Any suggestion where to place this? I general I think it is better to just have everything in one file, but we currently also have a dedicated RST for #109841
  6. Torben Hansen uploaded patch set 2 CR +1 V +1 05/25/26, 16:11

  7. Torben Hansen commented on patch set 1 05/25/26, 16:12

    Breaking-109869-RemovedMethodLevelSupportForIgnoreValidationAndValidateAttributes.rst:6 Reply

    Changed as discussed on slack
  8. Garvin Hicking commented on patch set 2 05/25/26, 16:30

    Breaking-109783-DeprecatedFunctionalityRemoved.rst:127

    We can link to the deprecation entry here like in the other bulletpoints. I'm not near an IDE but can help with this tomorrow
  9. Torben Hansen uploaded patch set 3 05/25/26, 16:37

  10. Torben Hansen commented on patch set 2 05/25/26, 16:37

    Breaking-109783-DeprecatedFunctionalityRemoved.rst:127 Reply

    Done
  11. Oliver Klee voted on patch set 3 CR +1 V +1 05/25/26, 16:41

  12. core-ci voted on patch set 3 V +1 05/25/26, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102401

  13. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 05/25/26, 17:59

  14. core-ci voted on patch set 4 V +1 05/25/26, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102402

  15. Oliver Klee voted on patch set 4 CR +1 V +1 05/25/26, 18:16

  16. Garvin Hicking voted on patch set 4 CR +2 V +2 05/25/26, 18:33

  17. Garvin Hicking merged patch set 5 05/25/26, 18:34