94134[!!!][TASK] Remove usage of #[IgnoreValidation] and #[Validate] attributes at method level
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 9
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-109783-DeprecatedFunctionalityRemoved.rst2+5 −0
- typo3/sysext/extbase/Classes/Attribute/IgnoreValidation.php+1 −1
- typo3/sysext/extbase/Classes/Attribute/Validate.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+2 −16
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/MethodParameterTest.php+0 −37
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithIgnoreValidationAttributesAtMethodScope.phpdeleted+0 −39
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithValidateAttributesAtMethodScope.phpdeleted+0 −31
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithValidateAttributeWithoutParam.phpdeleted+0 −31
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+0 −14
Review log 1417
-
Torben Hansen uploaded patch set 1 05/25/26, 06:09
-
core-ci voted on patch set 1 V +1 05/25/26, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102398
-
Oliver Klee voted on patch set 1 CR +1 V +1 05/25/26, 07:13
-
Garvin Hicking commented on patch set 1 05/25/26, 12:04
-
Torben Hansen commented on patch set 1 05/25/26, 12:06
Breaking-109869-RemovedMethodLevelSupportForIgnoreValidationAndValidateAttributes.rst:6ReplyI tried to find a suitable match for the deprecation in the general RST file but could not find a fitting match. Any suggestion where to place this? I general I think it is better to just have everything in one file, but we currently also have a dedicated RST for #109841 -
Torben Hansen uploaded patch set 2
CR +1V +105/25/26, 16:11 -
Torben Hansen commented on patch set 1 05/25/26, 16:12
Breaking-109869-RemovedMethodLevelSupportForIgnoreValidationAndValidateAttributes.rst:6ReplyChanged as discussed on slack -
Garvin Hicking commented on patch set 2 05/25/26, 16:30
Breaking-109783-DeprecatedFunctionalityRemoved.rst:127We can link to the deprecation entry here like in the other bulletpoints. I'm not near an IDE but can help with this tomorrow -
Torben Hansen uploaded patch set 3 05/25/26, 16:37
-
Torben Hansen commented on patch set 2 05/25/26, 16:37
Breaking-109783-DeprecatedFunctionalityRemoved.rst:127ReplyDone -
Oliver Klee voted on patch set 3 CR +1 V +1 05/25/26, 16:41
-
core-ci voted on patch set 3 V +1 05/25/26, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102401
-
Garvin Hicking updated the commit message in patch set 4
CR +1V +105/25/26, 17:59 -
core-ci voted on patch set 4 V +1 05/25/26, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102402
-
Oliver Klee voted on patch set 4 CR +1 V +1 05/25/26, 18:16
-
Garvin Hicking voted on patch set 4 CR +2 V +2 05/25/26, 18:33
-
Garvin Hicking merged patch set 5 05/25/26, 18:34
Breaking-109869-RemovedMethodLevelSupportForIgnoreValidationAndValidateAttributes.rst:6