Review main Merged

94159[BUGFIX] DateTime fields for slugs

Markus Klein CR +2 V +2 Easy +14 −6 updated 07/21/26, 12:37

Commit message

Slug generation within FormEngine relied on using the HTML id-attribute to identify value changes and trigger slug-generation.
This failed for datetime fields because the id-attribute initially memorized by the slug-element is moved to a different element during the date-time-picker initialization.

The solution is not to rely on the IDs of the elements, but to use the same selector, they were initially discovered with.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Markus Klein uploaded patch set 1 05/26/26, 14:58

  2. core-ci voted on patch set 1 V +1 05/26/26, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102442

  3. Georg Ringer voted on patch set 1 CR +1 V +1 07/05/26, 18:51

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 07/10/26, 20:51

  5. Benni Mack voted on patch set 1 CR +2 V +2 07/21/26, 12:37

  6. Benni Mack merged patch set 2 07/21/26, 12:37