Review main Merged

94160[BUGFIX] Skip label_alt processing when formattedLabel_userFunc is set

Benni Mack CR +2 V +2 Easy +32 −0 updated 06/04/26, 23:16

Commit message

When formattedLabel_userFunc is set for an inline child, label_alt
fields were still added to columnsToProcess, triggering unnecessary
DB queries for n:1 relations that were never used.

Add an early return in TcaColumnsProcessRecordTitle when isInlineChild
and formattedLabel_userFunc is set, mirroring TcaRecordTitle which
already skips those fields in that case.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 05/26/26, 16:22

  2. core-ci voted on patch set 1 V +1 05/26/26, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102443

  3. Oliver Klee voted on patch set 1 V +1 05/29/26, 06:59

  4. Oliver Klee voted on patch set 1 CR +1 05/31/26, 10:02

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 06/02/26, 05:55

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 06/04/26, 22:52

  7. Christian Kuhn merged patch set 2 06/04/26, 23:16