Review main Merged

94162[TASK] Allow TTY/non-interactive detection in runTests.sh

Garvin Hicking CR +2 V +2 Easy +7 −1 updated 05/28/26, 09:03

Commit message

The `runTests.sh` dispatcher can now auto-detect if it is
run inside a non-interactive environment (like sandboxed
coding agents, CI): The patch checks stdin and stdout for
an attached terminal and avoids the '-it' argument to
podman/docker to prevent warnings (podman), failures (docker)
and cluttered redirected output. '--init' is kept to retain
CTRL+C (SIGINT) handling in container PID 1.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Garvin Hicking uploaded patch set 1 05/26/26, 18:04

  2. core-ci voted on patch set 1 V +1 05/26/26, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102445

  3. Christian Kuhn commented on patch set 1 05/27/26, 23:13

    runTests.sh:935

    thanks! i think this is more about stdin (fd 0) than stdout (fd 1): when stdin is not a terminal, docker stops and podman emits a warning. when stdout is not a terminal, the output is just a bit cluttered with ^M. -> i'd go with both, and combine it as elif with the CI case. test cases: ./Build/Scripts/runTests.sh -s unit </dev/null - podman warning ./Build/Scripts/runTests.sh -s unit -b docker </dev/null - docker stop "cannot attach ..." ./Build/Scripts/runTests.sh -s unit >foo.txt - emit \r\n line endings in file Also, we should keep '--init' to retain forwarded CTRL+C (SIGINT) handling in PID 1

    runTests.sh:937

    i think we should skip this echo altogether, there is little point to have it.
  4. Christian Kuhn commented on patch set 1 05/27/26, 23:13

    runTests.sh:935 Reply

    Done
  5. Christian Kuhn uploaded patch set 2 V +1 05/27/26, 23:14

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 05/27/26, 23:19

  7. core-ci voted on patch set 2 V +1 05/27/26, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102493

  8. Garvin Hicking commented on patch set 2 05/28/26, 05:07

    Great, changes are fine by me!
  9. Stefan Bürk voted on patch set 2 CR +1 V +1 05/28/26, 07:50

  10. Garvin Hicking voted on patch set 2 CR +2 V +2 05/28/26, 08:45

  11. Garvin Hicking merged patch set 3 05/28/26, 09:03