Review main Abandoned

94163[TASK] Make form identifier unique by user session

Jochen Roth CR 0 V 0 Easy +9 −2 updated 05/28/26, 13:07

Commit message

The form protection cache identifier was not unique per backend
user session, which causes collisions in long-running PHP processes
like FrankenPHP or RoadRunner where multiple users share the same
process.

This is fixed by including the backend user's session identifier
in the cache key. A TypeError catch guards against the case where
BackendUserAuthentication exists but has no initialized session.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 611

  1. Jochen Roth uploaded patch set 1 05/26/26, 18:44

  2. core-ci voted on patch set 1 V -1 05/26/26, 18:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102446

  3. Jochen Roth uploaded patch set 2 V -1 05/27/26, 07:14

  4. core-ci voted on patch set 2 V -1 05/27/26, 07:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102462

  5. Jochen Roth uploaded patch set 3 V -1 05/27/26, 07:26

  6. core-ci voted on patch set 3 V -1 05/27/26, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102464

  7. Jochen Roth uploaded patch set 4 V -1 05/27/26, 09:08

  8. core-ci voted on patch set 4 V +1 05/27/26, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102468

  9. Jochen Roth updated the commit message in patch set 5 V +1 05/27/26, 18:46

  10. core-ci voted on patch set 5 V +1 05/27/26, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102485

  11. Jochen Roth abandoned the change 05/28/26, 13:07

    Currently we investigate performance and another approach to make this work in FrankenPHP. I might get back to it one day