Review main Ready for review Quiet

94165[BUGFIX] Handle missing context in site configuration edit route

Gianluigi Martino CR 0 V 0 Normal +80 −3 updated 10/01/26, 07:56

Commit message

SiteConfigurationController::editAction() required either "site" or
"pageUid". In backend navigation flows (for example via breadcrumb /
parent links), the route can be called without these arguments or only
with legacy "id", causing RuntimeException #1521561148.

The fix now:
- resolves legacy "id" to site identifier (or pageUid fallback)
- redirects to the site configuration overview if no valid edit context
  can be resolved at all

This prevents hard crashes and keeps navigation stable.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/65/94165/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/65/94165/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 5

Issues 1

Files 2

Review log 47

  1. Gianluigi Martino uploaded patch set 1 05/27/26, 09:39

  2. core-ci voted on patch set 1 V -1 05/27/26, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102469

  3. Gianluigi Martino commented on patch set 1 07/01/26, 11:58

    @garvin@hick.ing can you restart CI here or can you tell me, why i vot "Verified -1"?
  4. Stefan Bürk commented on patch set 1 07/01/26, 12:32

    Reply

    Restartet the e2e test
  5. core-ci voted on patch set 1 V +1 07/01/26, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102469

  6. Gianluigi Martino rebased onto patch set 2 V +1 10/01/26, 07:47

  7. core-ci voted on patch set 2 V +1 10/01/26, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109760