Review main Abandoned

94166[BUGFIX] Add CacheTag::sanitized() named constructor

Oliver Hader CR 0 V 0 Normal +69 −2 updated 05/28/26, 06:51

Commit message

Introduces a static factory method `CacheTag::sanitized()` that
accepts a prefix and suffix, validating the suffix against
`FrontendInterface::PATTERN_TAG`. If the suffix contains
characters not allowed in cache tag names, it is transparently
hashed via xxh128 to produce a safe, deterministic value.

Applies the new factory in `RequestHandler` when building the
site cache tag, ensuring site identifiers that contain special
characters (e.g. dots, quotes) do not produce invalid tags.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 4

Review log 35

  1. Oliver Hader uploaded patch set 1 05/27/26, 11:20

  2. core-ci voted on patch set 1 V -1 05/27/26, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102471

  3. Oliver Hader uploaded patch set 2 V -1 05/27/26, 20:45

  4. core-ci voted on patch set 2 V +1 05/27/26, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102486

  5. Oliver Hader abandoned the change 05/28/26, 06:51

    This was just an alternative proof-of-concept patch