94177[TASK] Revert "[TASK] Include current site in cache tag collection"
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Christian Kuhn +1
- Josua Vogel +1
- Oliver Hader +1
-
Verified V +2 Done
- Helmut Hummel +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Josua Vogel +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2225
-
Benjamin Franzke uploaded patch set 1 05/28/26, 07:56
-
core-ci voted on patch set 1 V +1 05/28/26, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102513
-
Josua Vogel voted on patch set 1 CR +1 V +1 05/28/26, 08:05
-
Oliver Klee updated the commit message in patch set 2
CR +1V +105/28/26, 08:11 -
Josua Vogel voted on patch set 2 CR +1 V +1 05/28/26, 08:13
-
core-ci voted on patch set 2 V +1 05/28/26, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102514
-
Garvin Hicking commented on patch set 2 CR +1 V +1 05/28/26, 08:38
Thanks! -
Helmut Hummel voted on patch set 2 CR +1 V +1 05/28/26, 08:53
-
Soren Malling voted on patch set 2 CR +1 V +1 05/28/26, 09:31
-
Stefan Bürk voted on patch set 2 CR +1 V +1 05/28/26, 10:33
-
Helmut Hummel commented on patch set 2 05/28/26, 10:52
Here is what I would write instead: ``` page { 1779954161 = TEXT 1779954161.addPageCacheTags.wrap = site_| 1779954161.addPageCacheTags.data = site:identifier } ``` -
Benjamin Franzke commented on patch set 2 05/28/26, 11:05
Reply
Thx for you recommendation. Please see: https://docs.typo3.org/permalink/t3tsref:confval-text-stdwrap > stdWrap properties are available on the very root level of the object. *This is non-standard!* You should use these stdWrap properties consistently to those of the other cObjects by accessing them through the property "stdWrap". -
Christian Kuhn voted on patch set 2 CR +1 05/28/26, 13:03
-
Helmut Hummel commented on patch set 2 05/29/26, 07:42
Reply
Okay. I understand this recommendation, although I don't necessarily share the concerns about root level usage. I would still use this then: ``` page { 1779954161 = TEXT 1779954161.stdWrap.addPageCacheTags.wrap = site_| 1779954161.stdWrap.addPageCacheTags.data = site:identifier } ``` I'd prefer TEXT over COA, and data and wrap over insertData, because insertData is a tricky thing: https://gist.github.com/pgampe/3023546 and the COA container functionality is not required here. -
Oliver Hader voted on patch set 2 CR +1 V +1 05/29/26, 08:15
-
Oliver Hader updated the commit message in patch set 3
CR +1V +105/29/26, 08:59 -
Oliver Hader commented on patch set 3 CR +1 V +1 05/29/26, 09:00
Reply
Thanks for the input. I took the freedom to use Helmut's suggestion to get move on with the revert of the underlying regression. -
core-ci voted on patch set 3 V +1 05/29/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102597
-
Josua Vogel voted on patch set 3 CR +1 V +1 05/29/26, 10:43
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 05/29/26, 10:59
-
Garvin Hicking voted on patch set 3 CR +1 V +1 05/29/26, 11:19
-
Christian Kuhn voted on patch set 3 CR +1 05/29/26, 12:21
-
Helmut Hummel voted on patch set 3 CR +1 V +1 05/30/26, 07:50
-
Helmut Hummel voted on patch set 3 CR +2 V +2 05/30/26, 07:51
-
Helmut Hummel merged patch set 4 05/30/26, 07:51