Review 14.3 Merged

94189[TASK] Clarify what the storage tests actually verify

Stefan Bürk CR +2 V +2 Easy +33 −0 updated 05/28/26, 13:14

Commit message

Change #109557 added functional tests for the database
storage feature #108653 in EXT:form and fell into the
trap that the inserted test data is double JSON-encoded
rather than an invalid JSON value in the database, in
test `readThrowsExceptionForDoubleEncodedJsonInDatabase()`.

To prepare for fixing the double-JSON-encoding issue
in #106638, this change:

* Renames the current test and enforces the JSON type
  for all supported databases.

* Adds a new test narrowing it down to `sqlite` to test
  against invalid JSON data in the column. This is right
  now still only double-encoded and prepares #106638 to
  be adjusted to test for genuinely invalid data. Without
  it it would fail inserting test-data with #106638 honored
  with errors like:

  PostgreSQL: Invalid text representation: 7 ERROR:
     invalid input syntax for type json

  MySQL: Invalid JSON text: "Invalid value." at position 1
    in value for column 'form_definition.configuration'.

  MariaDB: CONSTRAINT `form_definition.configuration` failed
    for `func_test_ft8bdcc58`.`form_definition`

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 4

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 05/28/26, 13:01

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/28/26, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102540

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 05/28/26, 13:14

  4. Stefan Bürk merged patch set 2 05/28/26, 13:14