Review main Abandoned

94195[FEATURE] Use dragonmantank/cron-expression in scheduler

Georg Ringer CR +1 V +1 Expert +402 −1453 updated 10/24/26, 06:57

Commit message

The scheduler's own cron parser, in place since v4.3, is replaced by
dragonmantank/cron-expression. Both classes were marked `@internal` and
are removed.

Besides support for L, W, # and ?, this fixes two calculation bugs:

* A cron command restricting hours and days at once, for example
  "0 9-17 * * 1-5", skipped the first slots of the next matching day,
  because the hour was matched before the day.
* Execution dates calculated across a daylight saving time switch were
  off by one hour, and an execution falling into the hour skipped in
  spring was dropped.

Long month and weekday names such as "January" are still accepted, and
descending ranges are still rejected when a task is saved.

Review

  • Code review CR +1
    • Simon Schaufelberger +1
  • Verified V +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1320

  1. Georg Ringer uploaded patch set 1 05/28/26, 21:07

  2. core-ci voted on patch set 1 V +1 05/28/26, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102566

  3. Georg Ringer uploaded patch set 2 V +1 09/18/26, 06:32

  4. Georg Ringer commented on patch set 2 09/18/26, 06:34

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 09/18/26, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108793

  6. Simon Schaufelberger commented on patch set 2 09/18/26, 09:29

    CronExpressionFactory.php:58

    That is only a statement but doesn't explain what this method really does.

    Index.rst:97

    use single backticks?
  7. Georg Ringer uploaded patch set 3 V +1 09/18/26, 13:06

  8. Georg Ringer commented on patch set 3 09/18/26, 13:07

    CronExpressionFactory.php:58 Reply

    Done

    Index.rst:97 Reply

    Done
  9. core-ci voted on patch set 3 V +1 09/18/26, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108807

  10. Oliver Klee updated the commit message in patch set 4 V +1 09/18/26, 13:36

  11. core-ci voted on patch set 4 V +1 09/18/26, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108809

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/18/26, 23:01

  13. Simon Schaufelberger uploaded patch set 5 CR +1 V +1 10/19/26, 12:30

  14. Simon Schaufelberger voted on patch set 5 CR +1 V +1 10/19/26, 12:31

  15. core-ci voted on patch set 5 V -1 10/19/26, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111640

  16. core-ci commented on patch set 5 10/19/26, 17:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111640

  17. Georg Ringer uploaded patch set 6 CR +1 V +1 10/19/26, 17:52

  18. core-ci voted on patch set 6 V +1 10/19/26, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111692

  19. Simon Schaufelberger voted on patch set 6 CR +1 V +1 10/19/26, 19:01

  20. Benni Mack abandoned the change 10/24/26, 06:57

    won't do for now