Review main Merged

94199[TASK] Remove FilePersistenceSlot and related dead code in ext:form

Josua Vogel CR +2 V +2 Hard +10 −294 updated 06/04/26, 09:55

Commit message

The FilePersistenceSlot was introduced as a
FAL-based security gate to prevent unauthorized manipulation of
.form.yaml files through the FAL API. It registered PSR-14 event
listeners for BeforeFileCreatedEvent, BeforeFileAddedEvent,
BeforeFileMovedEvent, BeforeFileRenamedEvent, BeforeFileReplacedEvent
and BeforeFileContentsSetEvent and required the form framework to
explicitly pre-authorize each FAL operation via allowInvocation()
with an HMAC-signed content signature.

With the removal of FileMountStorageAdapter (see #109790), no storage
adapter in ext:form writes form definitions through FAL anymore:

* ExtensionStorageAdapter writes directly via file_put_contents(),
  bypassing FAL entirely
* DatabaseStorageAdapter persists form definitions in the database

Since FilePersistenceSlot has no consumers left in ext:form, it is
removed along with:

* ImportExportHook – pre-authorized FAL file adds for .form.yaml
  files during ext:impexp imports, now obsolete
* FormDefinitionPersistenceException – only ever thrown by
  FilePersistenceSlot

YamlSource is simplified accordingly: the now-unused
buildCombinedIdentifier() method is removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 811

  1. Josua Vogel uploaded patch set 1 05/29/26, 06:03

  2. core-ci voted on patch set 1 V -1 05/29/26, 06:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102586

  3. Josua Vogel uploaded patch set 2 V -1 05/29/26, 06:28

  4. core-ci voted on patch set 2 V +1 05/29/26, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102589

  5. Josua Vogel updated the commit message in patch set 3 V +1 05/29/26, 06:41

  6. Oliver Klee voted on patch set 3 CR +1 05/29/26, 06:47

  7. core-ci voted on patch set 3 V +1 05/29/26, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102590

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 05/29/26, 19:39

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 05/29/26, 19:42

  10. Christian Kuhn merged patch set 4 05/29/26, 19:42

  11. Benjamin Franzke wrote 06/04/26, 09:55

    Created a revert of this change as I1dd6d3588237d853e3ae2a43f538914387df6bc3