Review main Merged

94201[TASK] Remove form_definitions-related fixtures from ext:impexp tests

Josua Vogel CR +2 V +2 Hard +0 −476 updated 05/30/26, 16:24

Commit message

With the removal of FileMountStorageAdapter in ext:form (#109790) and
the subsequent removal of FilePersistenceSlot, form definitions are no
longer stored as FAL files in fileadmin. The 1:/form_definitions/...
persistence identifier format is therefore no longer in use.

The following test coverage tested exactly this now-removed scenario:

* exportPagesAndRelatedTtContentWithFlexFormSoftrefs – exported a
  tt_content record referencing a FAL-based form definition
* importPagesAndRelatedTtContentKeepsRelationBetweenImportedFlexForm
  SoftReferenceAndRelatedRecord – verified file restoration on import
* importPagesAndRelatedTtContentCanKeepOriginalFlexFormSoftReference –
  verified SOFTREF_IMPORT_MODE_EXCLUDE behaviour
* importPagesAndRelatedTtContentCanEditFlexFormSoftReference –
  verified SOFTREF_IMPORT_MODE_EDITABLE behaviour

Remove these test methods along with all related fixture files:
form_sys_file.csv, tt_content-with-flexform-softrefs.csv,
pages-and-ttcontent-with-flexform-softrefs.xml, the three database
assertion CSVs and the flexFormWithSoftReference.form.yaml fixture
file. The pathsToLinkInTestInstance entry for fileadmin/form_definitions
is removed from the export test class accordingly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 911

  1. Josua Vogel uploaded patch set 1 05/29/26, 07:15

  2. Josua Vogel marked it work in progress 05/29/26, 07:15

  3. core-ci voted on patch set 1 V +1 05/29/26, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102591

  4. Josua Vogel updated the commit message in patch set 2 V +1 05/29/26, 07:25

  5. Josua Vogel marked it ready for review 05/29/26, 07:26

  6. core-ci voted on patch set 2 V +1 05/29/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102592

  7. Oliver Klee voted on patch set 2 V +1 05/29/26, 12:26

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 05/30/26, 16:22

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 05/30/26, 16:23

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 05/30/26, 16:24

  11. Stefan Bürk merged patch set 3 05/30/26, 16:24