Review main Merged

94208[BUGFIX] Guard against uninitialized setup array in TranslationService

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 05/30/26, 06:25

Commit message

Add hasSetup() check before calling loadTypoScriptLabelsFromExtension()
in TranslationService::translate(). Without it, getSetupArray() throws
a RuntimeException, which occurs during form finisher execution.

Note: Skipping the override when setup is unavailable means
TypoScript-based label overrides (plugin.tx_form._LOCAL_LANG)
are ignored in such finisher context. We need a separate issue
for this to ensure full TypoScript is loaded when finishers
are run.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Oli Bartsch uploaded patch set 1 05/29/26, 10:54

  2. Oliver Klee voted on patch set 1 CR +1 05/29/26, 11:03

  3. core-ci voted on patch set 1 V -1 05/29/26, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102610

  4. Oli Bartsch rebased onto patch set 2 CR +1 V -1 05/29/26, 13:21

  5. core-ci voted on patch set 2 V +1 05/29/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102615

  6. Josua Vogel voted on patch set 2 CR +1 V +1 05/29/26, 13:44

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 05/29/26, 15:03

  8. Christian Kuhn voted on patch set 2 CR +1 05/29/26, 15:21

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 05/29/26, 22:08

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 05/30/26, 06:25

  11. Oli Bartsch merged patch set 3 05/30/26, 06:25