Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
94214[TASK] Remove TYPO3_REQUEST from ext:form
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/94214/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/94214/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 36
- typo3/sysext/form/Classes/Command/TransferFormDefinitionCommand.php+4 −2
- typo3/sysext/form/Classes/ConfigurationModuleProvider/FormYamlProvider.php+5 −5
- typo3/sysext/form/Classes/Controller/FormEditorController.php+3 −0
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+1 −1
- typo3/sysext/form/Classes/Controller/FormManagerController.php+4 −2
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+10 −6
- typo3/sysext/form/Classes/Domain/Configuration/PersistenceConfigurationService.php+1 −28
- typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+1 −1
- typo3/sysext/form/Classes/EventListener/DataStructureIdentifierListener.php+7 −15
- typo3/sysext/form/Classes/EventListener/ValidateAdvancedPasswordRenderable.php+1 −1
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+17 −3
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+6 −0
- typo3/sysext/form/Classes/Service/TranslationService.php+24 −20
- typo3/sysext/form/Classes/Slot/ResourcePublicationSlot.php+1 −6
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+1 −2
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php+11 −1
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+10 −1
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+5 −1
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+6 −4
Show 16 more files
- typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.php+0 −2
- typo3/sysext/form/Tests/Functional/Domain/Finishers/FlashMessageFinisherTest.php+20 −9
- typo3/sysext/form/Tests/Functional/Domain/Finishers/SaveToDatabaseFinisherTest.php+0 −1
- typo3/sysext/form/Tests/Functional/Domain/Renderer/FluidFormRendererTest.php+0 −2
- typo3/sysext/form/Tests/Functional/Domain/Runtime/FormRuntimeTest.php+0 −2
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/FormPersistenceManagerTest.php+2 −1
- typo3/sysext/form/Tests/Functional/Mvc/Validation/CountValidatorTest.php+0 −4
- typo3/sysext/form/Tests/Functional/Mvc/Validation/DateRangeValidatorTest.php+0 −4
- typo3/sysext/form/Tests/Functional/Mvc/Validation/EmptyValidatorTest.php+0 −4
- typo3/sysext/form/Tests/Functional/Mvc/Validation/FileSizeValidatorTest.php+0 −4
- typo3/sysext/form/Tests/Functional/Mvc/Validation/MimeTypeValidatorTest.php+0 −4
- typo3/sysext/form/Tests/Functional/Service/TranslationServiceTest.php+30 −0
- typo3/sysext/form/Tests/Functional/Slot/ResourcePublicationSlotTest.php+0 −5
- typo3/sysext/form/Tests/Functional/Storage/ExtensionStorageAdapterFunctionalTest.php+6 −2
- typo3/sysext/form/Tests/Functional/ViewHelpers/RenderFormValueViewHelperTest.php+0 −2
- typo3/sysext/form/Tests/Functional/ViewHelpers/RenderRenderableViewHelperTest.php+0 −2
Review log 814
-
Josua Vogel uploaded patch set 1 05/30/26, 09:03
-
Josua Vogel marked it work in progress 05/30/26, 09:07
-
core-ci voted on patch set 1 V -1 05/30/26, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102666
-
Josua Vogel uploaded patch set 2
V -109/26/26, 10:42 -
core-ci voted on patch set 2 V -1 09/26/26, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109330
-
Josua Vogel uploaded patch set 3
V -109/26/26, 11:27 -
Josua Vogel updated the commit message in patch set 4 09/26/26, 11:27
-
core-ci voted on patch set 3 V -1 09/26/26, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109331
-
core-ci voted on patch set 4 V -1 09/26/26, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109332
-
Benni Mack uploaded patch set 5
V -111/11/26, 15:23 -
core-ci voted on patch set 5 V -1 11/11/26, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114109
-
Josua Vogel uploaded patch set 6
V -111/13/26, 13:08 -
core-ci voted on patch set 6 V +1 11/13/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114316
-
Josua Vogel commented on patch set 6 11/13/26, 13:26
This change is ready for review.