94222[TASK] Make PageRepository readonly
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- Josua Vogel +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- Josua Vogel +1
- core-ci +1 CI
Issues 2
Files 16
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+18 −17
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Storage/Typo3DbQueryParserTest.php2+2 −4
- typo3/sysext/frontend/Classes/Aspect/FileMetadataOverlayAspect.php+7 −5
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php+2 −2
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+2 −2
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+6 −5
- typo3/sysext/frontend/Classes/Page/PageInformationFactory.php+8 −11
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+4 −4
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+6 −8
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php2+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+3 −3
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+3 −4
- typo3/sysext/indexed_search/Tests/Functional/Controller/SearchControllerTest.php2+3 −0
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php2+3 −0
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php+2 −2
Review log 1419
-
Christian Kuhn uploaded patch set 1 05/30/26, 17:17
-
core-ci voted on patch set 1 V +1 05/30/26, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102690
-
Christian Kuhn uploaded patch set 2
V +105/30/26, 21:13 -
Christian Kuhn uploaded patch set 3 05/30/26, 21:21
-
core-ci voted on patch set 2 V -1 05/30/26, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102696
-
core-ci voted on patch set 3 V -1 05/30/26, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102697
-
Christian Kuhn uploaded patch set 4
V -105/30/26, 21:59 -
core-ci voted on patch set 4 V +1 05/30/26, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102699
-
Oliver Klee commented on patch set 4 CR +1 V +1 05/31/26, 09:05
Added some comments, none of them blocking.Typo3DbQueryParserTest.php:607Hit this snag on reading: Shouldn't this also be `$context` instead of a new instance? (Not that it would have any effect on the test.)DatabaseRecordLinkBuilderTest.php:157Note: This (and many other things) probably should be a stub, not a mock. But that's a topic for another change.SearchControllerTest.php:93Should we directly make this a stub (for following best practices) or keep it a mock for now (for consistency)?RedirectServiceTest.php:100Ditto (mock vs. stub) -
Stefan Bürk voted on patch set 4 CR +1 V +1 05/31/26, 10:53
-
Josua Vogel voted on patch set 4 CR +1 V +1 05/31/26, 15:00
-
Christian Kuhn commented on patch set 4 06/01/26, 10:57
Typo3DbQueryParserTest.php:607ReplyDoneDatabaseRecordLinkBuilderTest.php:157Replyyes. i took care of that in fluid standalone already. i think the way to go with this is to have a series of dedicated changes when php version and thus phpunit version for v15 are sorted out. i'll not start working on this as drive-by changes right now.SearchControllerTest.php:93Replykeep for now. switching to stubs should be done in a dedicated effort when we're ready to do this.RedirectServiceTest.php:100ReplyDone -
Christian Kuhn uploaded patch set 5
CR +1V +106/01/26, 10:58 -
core-ci voted on patch set 5 V +1 06/01/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102755
-
Stefan Bürk voted on patch set 5 CR +1 V +1 06/01/26, 11:06
-
Oliver Klee voted on patch set 5 CR +1 V +1 06/01/26, 11:06
-
Josua Vogel voted on patch set 5 CR +1 V +1 06/01/26, 11:10
-
Christian Kuhn voted on patch set 5 CR +2 V +2 06/01/26, 11:12
-
Christian Kuhn merged patch set 6 06/01/26, 11:12