Review main Merged Breaking

94223[!!!][TASK] Remove extbase parameter type evaluation via DocBlock

Christian Kuhn CR +2 V +2 Normal +64 −118 updated 05/31/26, 13:41

Commit message

Extbase used to recover the target type of a reflected
method parameter from the method DocBlock when no native
PHP type declaration was given, for instance to type a
controller action argument via an `@param \My\Model $item`
tag.

We deprecated this fallback with #94115 in v11 in favor of
native PHP type declarations, which have been available since
v10. A validated argument now carries its declaration where
the type hint belongs and there is no remaining reason to dig
a type out of the DocBlock.

The patch drops the DocBlock parameter type detection in
`ClassSchema` together with the `RuntimeException` that guarded
the `#[Validate]` plus DocBlock-type combination. A parameter
type is now determined solely from its native PHP type declaration.
Action arguments lacking one raise an `InvalidArgumentTypeException`
on dispatch, and in combination with `#[Validate]` the class schema
build raises `InvalidTypeHintException`.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 67

  1. Christian Kuhn uploaded patch set 1 05/30/26, 20:22

  2. core-ci voted on patch set 1 V +1 05/30/26, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102692

  3. Oliver Klee voted on patch set 1 CR +1 V +1 05/31/26, 09:00

  4. Stefan Bürk commented on patch set 1 CR -1 05/31/26, 11:37

    Investigating something ...
  5. Stefan Bürk commented on patch set 1 CR +1 V +1 05/31/26, 13:39

    Reply

    ... feeling turned out to be wrong.
  6. Stefan Bürk voted on patch set 1 CR +2 V +2 05/31/26, 13:41

  7. Stefan Bürk merged patch set 2 05/31/26, 13:41