94225[TASK] Reduce SingletonInterface usages
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 24
- typo3/sysext/core/Classes/Mail/MemorySpool.php+1 −2
- typo3/sysext/core/Tests/Functional/Log/LoggerInterfaceTest.php+13 −26
- typo3/sysext/core/Tests/Functional/Package/Event/PackageInitializationEventTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Schema/SearchableSchemaFieldsCollectorTest.php+11 −11
- typo3/sysext/core/Tests/Functional/Schema/VisibleSchemaFieldsCollectorTest.php+2 −2
- typo3/sysext/dashboard/Classes/DashboardPresetRegistry.php+1 −3
- typo3/sysext/dashboard/Classes/WidgetGroupRegistry.php+1 −3
- typo3/sysext/dashboard/Classes/WidgetRegistry.php+3 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfigurationService.php+1 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+3 −2
- typo3/sysext/extbase/Classes/Property/PropertyMapper.php+3 −2
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfigurationBuilder.php+1 −2
- typo3/sysext/extbase/Classes/Service/ActionAuthorizationService.php+1 −2
- typo3/sysext/extbase/Classes/Service/CacheService.php+1 −2
- typo3/sysext/extbase/Classes/Service/FileHandlingService.php+3 −2
- typo3/sysext/extbase/Tests/Functional/Service/FileHandlingServiceTest.php2+15 −24
- typo3/sysext/extensionmanager/Classes/Domain/Model/DownloadQueue.php+1 −2
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+1 −2
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php+1 −2
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+1 −2
Show 4 more files
Review log 913
-
Christian Kuhn uploaded patch set 1 05/30/26, 21:03
-
core-ci voted on patch set 1 V -1 05/30/26, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102695
-
Christian Kuhn uploaded patch set 2
V -105/30/26, 21:58 -
core-ci voted on patch set 2 V -1 05/30/26, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102698
-
Christian Kuhn uploaded patch set 3
V -105/30/26, 23:06 -
core-ci voted on patch set 3 V +1 05/30/26, 23:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102702
-
Christian Kuhn updated the commit message in patch set 4
V +105/30/26, 23:21 -
core-ci voted on patch set 4 V +1 05/30/26, 23:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102703
-
Oliver Klee commented on patch set 4 CR +1 V +1 05/31/26, 09:14
-
Stefan Bürk voted on patch set 4 CR +1 V +1 05/31/26, 11:04
-
Christian Kuhn commented on patch set 4 06/01/26, 11:37
FileHandlingServiceTest.php:59Replykinda matter of taste: i tend to kill setUp() with fire where ever i can ;) it makes tests more standalone without side-effects between each other. i think sebastian bergmann once said this is a good idea and setUp() is heavily overused and often introduces more issues than it solves. i also try to use name $subject for SuT, but didn't do that in this case since the one-liners are so convenient here. i'll keep the strategy in this case. -
Christian Kuhn voted on patch set 4 CR +2 V +2 06/01/26, 11:38
-
Christian Kuhn merged patch set 5 06/01/26, 11:38
FileHandlingServiceTest.php:59