Review main Merged

94225[TASK] Reduce SingletonInterface usages

Christian Kuhn CR +2 V +2 Normal +73 −107 updated 06/01/26, 11:38

Commit message

We want to phase out SingletonInterface: with the DI
container managing service lifecycle, the marker is
redundant for classes that are container services anyway.

The patch removes "implements SingletonInterface" from a
batch of 'simple' cases.

Some tests are streamlined along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 913

  1. Christian Kuhn uploaded patch set 1 05/30/26, 21:03

  2. core-ci voted on patch set 1 V -1 05/30/26, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102695

  3. Christian Kuhn uploaded patch set 2 V -1 05/30/26, 21:58

  4. core-ci voted on patch set 2 V -1 05/30/26, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102698

  5. Christian Kuhn uploaded patch set 3 V -1 05/30/26, 23:06

  6. core-ci voted on patch set 3 V +1 05/30/26, 23:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102702

  7. Christian Kuhn updated the commit message in patch set 4 V +1 05/30/26, 23:21

  8. core-ci voted on patch set 4 V +1 05/30/26, 23:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102703

  9. Oliver Klee commented on patch set 4 CR +1 V +1 05/31/26, 09:14

    FileHandlingServiceTest.php:59

    Not blocking: I'd slightly prefer to keep the file handling service a property in the testcase to make it more visible that it's a dependency we use.
  10. Stefan Bürk voted on patch set 4 CR +1 V +1 05/31/26, 11:04

  11. Christian Kuhn commented on patch set 4 06/01/26, 11:37

    FileHandlingServiceTest.php:59 Reply

    kinda matter of taste: i tend to kill setUp() with fire where ever i can ;) it makes tests more standalone without side-effects between each other. i think sebastian bergmann once said this is a good idea and setUp() is heavily overused and often introduces more issues than it solves. i also try to use name $subject for SuT, but didn't do that in this case since the one-liners are so convenient here. i'll keep the strategy in this case.
  12. Christian Kuhn voted on patch set 4 CR +2 V +2 06/01/26, 11:38

  13. Christian Kuhn merged patch set 5 06/01/26, 11:38