94227[TASK] Dissolve LoggerAwareInterface in various services
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 20
- typo3/sysext/backend/Classes/Controller/File/ImageProcessController.php2+6 −14
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+5 −12
- typo3/sysext/backend/Classes/Middleware/PageContextInitialization.php2+4 −6
- typo3/sysext/backend/Classes/Security/SudoMode/Access/AccessStorage.php+5 −7
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+4 −6
- typo3/sysext/core/Classes/Middleware/RequestTokenMiddleware.php+6 −7
- typo3/sysext/core/Tests/Functional/Html/EventListener/RteHtmlParserTest.php+5 −4
- typo3/sysext/core/Tests/Unit/Html/RteHtmlParserTest.php+13 −12
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+3 −5
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php1+1 −5
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+6 −2
- typo3/sysext/felogin/Classes/Configuration/RecoveryConfiguration.php+4 −8
- typo3/sysext/felogin/Classes/Validation/RedirectUrlValidator.php+4 −6
- typo3/sysext/felogin/Tests/Unit/Configuration/RecoveryConfigurationTest.php+0 −6
- typo3/sysext/felogin/Tests/Unit/Validation/RedirectUrlValidatorTest.php+1 −2
- typo3/sysext/filelist/Classes/Controller/FileListController.php+3 −5
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+6 −8
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php+4 −6
- typo3/sysext/redirects/Classes/Service/SlugService.php+4 −6
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+10 −10
Review log 1319
-
Christian Kuhn uploaded patch set 1 05/31/26, 00:34
-
core-ci voted on patch set 1 V -1 05/31/26, 00:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102705
-
Christian Kuhn uploaded patch set 2
V -105/31/26, 00:53 -
Christian Kuhn uploaded patch set 3 05/31/26, 00:55
-
Christian Kuhn uploaded patch set 4 05/31/26, 00:59
-
core-ci voted on patch set 2 V -1 05/31/26, 01:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102706
-
core-ci voted on patch set 3 V +1 05/31/26, 01:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102707
-
core-ci voted on patch set 4 V +1 05/31/26, 01:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102708
-
Christian Kuhn updated the commit message in patch set 5
V +105/31/26, 01:17 -
core-ci voted on patch set 5 V +1 05/31/26, 01:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102710
-
Oliver Klee commented on patch set 5 V +1 05/31/26, 09:24
Looks generally good. I think we can tighten some screws a bit more. I've added some comments for this.ImageProcessController.php:37Can be `private`. Ditto in many other classes that this change changes (haven't checked in detail). At least in the `@internal` classes, and maybe in all changed classes.PageContextInitialization.php:58AFAICS, we can make this class readonly now.InstallUtility.php:41Not used - good cleanup! -
Stefan Bürk voted on patch set 5 CR +1 V +1 05/31/26, 11:11
-
Christian Kuhn commented on patch set 5 06/01/26, 11:24
ImageProcessController.php:37ReplyDone here. The issue is that we still have no good guideline regarding protected vs. private DI services. I hope we can come up with something in the future, but for now, this is rather based on gut feelings: Going protected in this case is the least breaking decision. I'll however go through the cases in this patch and will switch to private in cases where other dependencies are private as well already, or where classes are more or less designed to be leaf-classes and/or unlikely to be xclassed. This strategy narrows this one down to private, but leaves more troublesome cases with protected.PageContextInitialization.php:58Replythx. good catch. -
Christian Kuhn uploaded patch set 6
CR +1V +106/01/26, 11:24 -
core-ci voted on patch set 6 V +1 06/01/26, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102756
-
Oliver Klee voted on patch set 6 CR +1 V +1 06/01/26, 11:34
-
Stefan Bürk voted on patch set 6 CR +1 V +1 06/01/26, 11:34
-
Christian Kuhn voted on patch set 6 CR +2 V +2 06/01/26, 11:41
-
Christian Kuhn merged patch set 7 06/01/26, 11:42