Review main Abandoned

94230[TASK] Refactor ext:form TranslationService

Josua Vogel CR 0 V 0 Hard +692 −182 updated 06/05/26, 15:53

Commit message

* Remove SingletonInterface in favor of Symfony DI shared service (shared=true
  by default), making SingletonInterface usage unnecessary
* Introduce FormTranslationKeyChainBuilderInterface and FormTranslationKeyChainBuilder
  under Domain/Translation/ to encapsulate form-specific LLL key chain logic;
  eliminates duplicated inline key-building loops from TranslationService
* Use Translator API (LanguageService::label()) instead of manual key parsing,
  removing PathUtility dependency and reducing translate() to a clean single-call
  reference-based lookup
* createLanguageService() was calling GeneralUtility::makeInstance(Locales::class)
  instead of using the already-injected $this->locales
* Fix translateValuesRecursive() to sort $translationFiles only once before
  recursion via a private translateValuesRecursiveInternal() worker method,
  instead of redundantly on each nested level
* Replace GeneralUtility::makeInstance(TranslationService::class) with proper
  DI injection in ValidateAdvancedPasswordRenderable (constructor injection)
  and UploadedFileReferenceConverter (injectTranslationService())
* Add unit tests for FormTranslationKeyChainBuilder covering all four build*()
  methods including originalFormIdentifier and elementIsFormRuntime variants

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 7

Review log 47

  1. Josua Vogel uploaded patch set 1 05/31/26, 16:54

  2. Josua Vogel uploaded patch set 2 05/31/26, 16:59

  3. core-ci voted on patch set 1 V -1 05/31/26, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102724

  4. core-ci voted on patch set 2 V -1 05/31/26, 17:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102725

  5. Josua Vogel uploaded patch set 3 V -1 05/31/26, 17:11

  6. core-ci voted on patch set 3 V +1 05/31/26, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102726

  7. Josua Vogel abandoned the change 06/05/26, 15:53