Review main Merged

94233[BUGFIX] Pass hasDiff parameter at correct position to workspaceState()

Andreas Häfner CR +2 V +2 Easy +1 −1 updated 06/01/26, 13:25

Commit message

If table has no hidden field, default hidden parameters have to be
passed to GridDataService::workspaceState() to get $hasDiff recognized
correctly at last parameter position.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Ravi Sachaniya +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Ravi Sachaniya +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Andreas Häfner uploaded patch set 1 06/01/26, 09:00

  2. core-ci voted on patch set 1 V +1 06/01/26, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102753

  3. Ravi Sachaniya voted on patch set 1 CR +1 V +1 06/01/26, 11:49

  4. Christian Kuhn updated the commit message in patch set 2 CR +1 V +1 06/01/26, 12:31

  5. core-ci voted on patch set 2 V +1 06/01/26, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102758

  6. Andreas Häfner uploaded patch set 3 06/01/26, 12:48

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  7. Christian Kuhn updated the commit message in patch set 4 V +1 06/01/26, 12:51

  8. Christian Kuhn voted on patch set 4 CR +1 V +1 06/01/26, 12:51

  9. Ravi Sachaniya voted on patch set 4 CR +1 V +1 06/01/26, 12:52

  10. Christian Kuhn voted on patch set 4 CR +2 V +2 06/01/26, 12:53

  11. core-ci voted on patch set 3 V +1 06/01/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102760

  12. core-ci voted on patch set 4 V +1 06/01/26, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102761

  13. Christian Kuhn merged patch set 5 06/01/26, 13:25