Review main Merged

94241[BUGFIX] Enforce isEnabled() check in ResetPasswordController

Oliver Hader CR +2 V +2 Normal +80 −0 updated 06/02/26, 09:22

Commit message

The BE.passwordReset configuration flag was only used to hide
the reset UI elements, but all four controller actions processed
requests regardless of the setting. This allowed bypassing the
disabled state by posting directly to the public reset routes.

All action methods now check isEnabled() at the start and
redirect to the login form when password reset is disabled.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oliver Hader uploaded patch set 1 06/01/26, 18:15

  2. core-ci voted on patch set 1 V +1 06/01/26, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102775

  3. Oliver Klee voted on patch set 1 CR +1 V +1 06/01/26, 20:26

  4. Christian Kuhn commented on patch set 1 CR +1 V +1 06/01/26, 21:30

    ResetPasswordControllerTest.php:113

    this is obsolete, probably copied from other tests in this class, dating back to a time where the code actively still used that fallback. patch is ok, we can go with it, i just added a mental not that we should look at tests (in main) to see where globals typo3-request is obsolete meanwhile, and have a broader cleanup for this - i guess there are more cases.
  5. Garvin Hicking voted on patch set 1 CR +1 V +1 06/02/26, 04:53

  6. Thomas Hohn voted on patch set 1 CR +1 V +1 06/02/26, 05:07

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 06/02/26, 09:03

  8. Christian Kuhn merged patch set 2 06/02/26, 09:22