94244[TASK] Streamline test cases
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benjamin Franzke +1
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oliver Hader +2
- Benjamin Franzke +1
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Tests/Unit/Tree/TreeNodeTest.php+1 −1
- typo3/sysext/core/Tests/Functional/TypoScript/AST/AstBuilderInterfaceTest.php2+15 −6
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/SysTemplateTreeBuilderTest.php+20 −11
- typo3/sysext/core/Tests/Functional/RegistryTest.php2+33 −24
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderInterfaceTest.php+13 −4
- typo3/sysext/scheduler/Tests/Functional/Migration/SchedulerDatabaseStorageMigrationTest.php+2 −2
Review log 1316
-
Oliver Hader uploaded patch set 1 06/01/26, 21:02
-
core-ci voted on patch set 1 V +1 06/01/26, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102778
-
Oliver Klee commented on patch set 1 V +1 06/01/26, 21:22
AstBuilderInterfaceTest.php:110If I read this correctly, this tests whether `$ast` is serializable. It is not clear to me how this infers whether `$ast` is cacheable. Maybe rename or add a comment? -
Oliver Hader uploaded patch set 2
V +106/02/26, 05:30 -
Oliver Hader commented on patch set 2 06/02/26, 05:32
RegistryTest.php:31ReplyI move the instantiation to a new class member variable know.AstBuilderInterfaceTest.php:110ReplyI see. I did both now - renamed the method and added a comment. -
Garvin Hicking voted on patch set 2 CR +1 V +1 06/02/26, 05:34
-
core-ci voted on patch set 2 V +1 06/02/26, 05:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102808
-
Oliver Klee voted on patch set 2 CR +1 V +1 06/02/26, 07:32
-
Christian Kuhn voted on patch set 2 CR +1 V +1 06/02/26, 09:07
-
Oliver Hader uploaded patch set 3
CR +1V +106/02/26, 09:51 -
core-ci voted on patch set 3 V +1 06/02/26, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102818
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 06/02/26, 10:31
-
Oliver Klee voted on patch set 3 CR +1 V +1 06/02/26, 10:36
-
Christian Kuhn voted on patch set 3 CR +1 V +1 06/02/26, 10:59
-
Oliver Hader voted on patch set 3 CR +2 V +2 06/02/26, 11:00
-
Oliver Hader merged patch set 4 06/02/26, 11:00
RegistryTest.php:31