Review main Merged

94244[TASK] Streamline test cases

Oliver Hader CR +2 V +2 Normal +84 −48 updated 06/02/26, 11:00

Commit message

* make more use of DI in functional test cases
* more explicit deserialization usage in test cases

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1316

  1. Oliver Hader uploaded patch set 1 06/01/26, 21:02

  2. core-ci voted on patch set 1 V +1 06/01/26, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102778

  3. Oliver Klee commented on patch set 1 V +1 06/01/26, 21:22

    RegistryTest.php:31

    Now we have `get()` twice, and the test is about `get()`. I find this a bit confusing, and it took me an additional moment to grok this and match this with the statement given by the (very communicative) test name. I suggest using a local variable `$subject`, on which we then call `get()`. This will make it more obvious which `get()` is the tested call. (Ditto for the other changed places.)

    AstBuilderInterfaceTest.php:110

    If I read this correctly, this tests whether `$ast` is serializable. It is not clear to me how this infers whether `$ast` is cacheable. Maybe rename or add a comment?
  4. Oliver Hader uploaded patch set 2 V +1 06/02/26, 05:30

  5. Oliver Hader commented on patch set 2 06/02/26, 05:32

    RegistryTest.php:31 Reply

    I move the instantiation to a new class member variable know.

    AstBuilderInterfaceTest.php:110 Reply

    I see. I did both now - renamed the method and added a comment.
  6. Garvin Hicking voted on patch set 2 CR +1 V +1 06/02/26, 05:34

  7. core-ci voted on patch set 2 V +1 06/02/26, 05:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102808

  8. Oliver Klee voted on patch set 2 CR +1 V +1 06/02/26, 07:32

  9. Christian Kuhn voted on patch set 2 CR +1 V +1 06/02/26, 09:07

  10. Oliver Hader uploaded patch set 3 CR +1 V +1 06/02/26, 09:51

  11. core-ci voted on patch set 3 V +1 06/02/26, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102818

  12. Benjamin Franzke voted on patch set 3 CR +1 V +1 06/02/26, 10:31

  13. Oliver Klee voted on patch set 3 CR +1 V +1 06/02/26, 10:36

  14. Christian Kuhn voted on patch set 3 CR +1 V +1 06/02/26, 10:59

  15. Oliver Hader voted on patch set 3 CR +2 V +2 06/02/26, 11:00

  16. Oliver Hader merged patch set 4 06/02/26, 11:00