Review main Merged Breaking

94257[!!!][TASK] Remove deprecated InfoboxViewHelper state constants

Christian Kuhn CR +2 V +2 Easy +11 −27 updated 06/03/26, 08:03

Commit message

The constants of \TYPO3\CMS\Fluid\ViewHelpers\Be\InfoboxViewHelper
that mirrored the box severity have been deprecated with v14 and
are now removed:

* InfoboxViewHelper::STATE_NOTICE
* InfoboxViewHelper::STATE_INFO
* InfoboxViewHelper::STATE_OK
* InfoboxViewHelper::STATE_WARNING
* InfoboxViewHelper::STATE_ERROR

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1113

  1. Christian Kuhn uploaded patch set 1 06/02/26, 00:03

  2. core-ci voted on patch set 1 V +1 06/02/26, 00:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102793

  3. Garvin Hicking commented on patch set 1 06/02/26, 05:44

    InfoboxViewHelper.php:61

    This needs adoption?
  4. Oliver Klee voted on patch set 1 V +1 06/02/26, 07:32

  5. Christian Kuhn uploaded patch set 2 V +1 06/02/26, 11:10

  6. Christian Kuhn commented on patch set 1 06/02/26, 11:10

    InfoboxViewHelper.php:61 Reply

    reworded. thx.
  7. core-ci voted on patch set 2 V +1 06/02/26, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102825

  8. Oliver Klee voted on patch set 2 CR +1 V +1 06/02/26, 11:21

  9. Garvin Hicking commented on patch set 2 06/02/26, 12:43

    InfoboxViewHelper.php:61 Reply

    My point was Inthought we would only accept the enum now and not have int fallback l, for type safety?
  10. Christian Kuhn commented on patch set 2 06/02/26, 16:36

    InfoboxViewHelper.php:61 Reply

    that would change the signature within templates, which wasn't deprecated as such, so i didn't consider it in this patch.
  11. Garvin Hicking commented on patch set 2 CR +1 V +1 06/03/26, 05:04

    InfoboxViewHelper.php:61 Reply

    Ah ok, understood.
  12. Christian Kuhn voted on patch set 2 CR +2 V +2 06/03/26, 08:03

  13. Christian Kuhn merged patch set 3 06/03/26, 08:03