94257[!!!][TASK] Remove deprecated InfoboxViewHelper state constants
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 3
Files 3
Review log 1113
-
Christian Kuhn uploaded patch set 1 06/02/26, 00:03
-
core-ci voted on patch set 1 V +1 06/02/26, 00:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102793
-
Garvin Hicking commented on patch set 1 06/02/26, 05:44
-
Oliver Klee voted on patch set 1 V +1 06/02/26, 07:32
-
Christian Kuhn uploaded patch set 2
V +106/02/26, 11:10 -
Christian Kuhn commented on patch set 1 06/02/26, 11:10
InfoboxViewHelper.php:61Replyreworded. thx. -
core-ci voted on patch set 2 V +1 06/02/26, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102825
-
Oliver Klee voted on patch set 2 CR +1 V +1 06/02/26, 11:21
-
Garvin Hicking commented on patch set 2 06/02/26, 12:43
InfoboxViewHelper.php:61ReplyMy point was Inthought we would only accept the enum now and not have int fallback l, for type safety? -
Christian Kuhn commented on patch set 2 06/02/26, 16:36
InfoboxViewHelper.php:61Replythat would change the signature within templates, which wasn't deprecated as such, so i didn't consider it in this patch. -
Garvin Hicking commented on patch set 2 CR +1 V +1 06/03/26, 05:04
InfoboxViewHelper.php:61ReplyAh ok, understood. -
Christian Kuhn voted on patch set 2 CR +2 V +2 06/03/26, 08:03
-
Christian Kuhn merged patch set 3 06/03/26, 08:03
InfoboxViewHelper.php:61