Review main Merged Breaking

94258[!!!][TASK] Remove deprecated passwordRules field control option

Christian Kuhn CR +2 V +2 Normal +50 −80 updated 06/03/26, 19:04

Commit message

The "passwordRules" option of the "passwordGenerator" field control
has been deprecated with v14 and is now removed. Password generation
is configured through password policies registered in
$GLOBALS['TYPO3_CONF_VARS']['SYS']['passwordPolicies'] and
referenced by name via the "passwordPolicy" option instead.

The removal spans the full feature path:

* PasswordGeneratorController no longer generates a password directly
  from rules.
* The passwordGenerator field control no longer emits the
  "data-password-rules" attribute, and the field control JavaScript no
  longer reads or sends it.
* The styleguide "passwordGenerator" demos are migrated to dedicated
  password policies registered in ext_localconf.php.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 8

Review log 1214

  1. Christian Kuhn uploaded patch set 1 06/02/26, 00:27

  2. core-ci voted on patch set 1 V -1 06/02/26, 00:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102794

  3. Christian Kuhn uploaded patch set 2 V -1 06/02/26, 01:05

  4. core-ci voted on patch set 2 V +1 06/02/26, 01:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102797

  5. Oliver Klee voted on patch set 2 CR +1 V +1 06/02/26, 07:27

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 06/02/26, 09:36

  7. Simon Schaufelberger commented on patch set 2 CR 0 V 0 06/02/26, 09:40

    Let me double check if there can also some config in DefaultConfiguration be removed or not.
  8. Stefan Bürk voted on patch set 2 CR +1 V +1 06/02/26, 10:54

  9. Stefan Bürk commented on patch set 2 06/03/26, 09:08

    Reply

    @simonschaufi+typo3@gmail.com have you checked it ? Could not identify what you possible have ment.
  10. Christian Kuhn commented on patch set 2 06/03/26, 09:40

    Reply

    Hey. I pinged Simon, he is currently very time restricted. We'll go with a merge here for now. In case we can go with additional removals in DefaultConfiguration, we can do that with a change on top of this one.
  11. Christian Kuhn voted on patch set 2 CR +2 V +2 06/03/26, 09:40

  12. Christian Kuhn merged patch set 3 06/03/26, 09:40

  13. Christian Kuhn commented on patch set 3 06/03/26, 18:57

    Reply

    feedback: "nah, all good".
  14. Simon Schaufelberger voted on patch set 3 CR +1 V +1 06/03/26, 19:04