94259[!!!][TASK] Remove legacy cHash fallback (fallbackToLegacyHash)
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- Oliver Hader +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 6
- typo3/sysext/core/Classes/Service/SilentConfigurationUpgradeService.php+2 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −2
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-109783-DeprecatedFunctionalityRemoved.rst+1 −0
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php+0 −6
- typo3/sysext/frontend/Classes/Page/CacheHashCalculator.php+0 −14
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php2+0 −6
Review log 78
-
Christian Kuhn uploaded patch set 1 06/02/26, 01:00
-
core-ci voted on patch set 1 V +1 06/02/26, 01:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102795
-
Oliver Hader voted on patch set 1 CR +1 06/02/26, 05:19
-
Garvin Hicking voted on patch set 1 CR +1 V +1 06/02/26, 05:35
-
Oliver Klee commented on patch set 1 V +1 06/02/26, 07:28
-
Stefan Bürk voted on patch set 1 CR +1 V +1 06/02/26, 10:59
-
Christian Kuhn commented on patch set 1 CR +2 V +2 06/02/26, 11:18
SiteRequestTest.php:832Replythx. i didn't spot this. codewise: yes, could be simplified. strategically: keep - there are two commented out @todo that will require this permutation again, plus keeping it mirrors the other tests. i hope it's ok to resolve and keep in this case. -
Christian Kuhn merged patch set 2 06/02/26, 11:19
SiteRequestTest.php:832