Review main Merged Breaking

94259[!!!][TASK] Remove legacy cHash fallback (fallbackToLegacyHash)

Christian Kuhn CR +2 V +2 Easy +3 −28 updated 06/02/26, 11:19

Commit message

With the switch to HMAC-SHA3 cHash algorithms in v14, option
$GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash']['fallbackToLegacyHash']
was introduced as a transitional aid to keep validating old
md5-based cHashes. This transition is over, and the fallback
is now removed.

The patch removes CacheHashCalculator->calculateLegacyCacheHash(),
the fallback branch in PageArgumentValidator, and the
"fallbackToLegacyHash" default in DefaultConfiguration.
The now obsolete "FE/cacheHash/fallbackToLegacyHash" setting is removed
from persisted configuration by the SilentConfigurationUpgradeService.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 78

  1. Christian Kuhn uploaded patch set 1 06/02/26, 01:00

  2. core-ci voted on patch set 1 V +1 06/02/26, 01:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102795

  3. Oliver Hader voted on patch set 1 CR +1 06/02/26, 05:19

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 06/02/26, 05:35

  5. Oliver Klee commented on patch set 1 V +1 06/02/26, 07:28

    SiteRequestTest.php:832

    Do we still need this call, or can this be simplified now?
  6. Stefan Bürk voted on patch set 1 CR +1 V +1 06/02/26, 10:59

  7. Christian Kuhn commented on patch set 1 CR +2 V +2 06/02/26, 11:18

    SiteRequestTest.php:832 Reply

    thx. i didn't spot this. codewise: yes, could be simplified. strategically: keep - there are two commented out @todo that will require this permutation again, plus keeping it mirrors the other tests. i hope it's ok to resolve and keep in this case.
  8. Christian Kuhn merged patch set 2 06/02/26, 11:19