Review main Merged

94280[BUGFIX] Ensure type of `FolderInterface` when building folder rootline

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 06/02/26, 19:17

Commit message

Before #106524, the code in the TreeController checked for the correct
type of `$nextFolder`. Now, due to a misguided null-coalesce check, we
may encounter an issue that `null` is treated as an object.

The check is now added again but widened to check for `FolderInterface`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 06/02/26, 13:16

  2. core-ci voted on patch set 1 V +1 06/02/26, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102829

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 06/02/26, 13:33

  4. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 06/02/26, 13:35

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 06/02/26, 13:35

  6. core-ci voted on patch set 2 V +1 06/02/26, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102830

  7. Oliver Klee voted on patch set 2 CR +1 V +1 06/02/26, 14:29

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 06/02/26, 18:57

  9. Christian Kuhn merged patch set 3 06/02/26, 19:17