94286[BUGFIX] Prevent loading of commands with incomplete Container
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/94286/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/94286/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 1
Issues 1
Files 9
- typo3/sysext/core/Classes/Console/CommandApplication.php+8 −1
- typo3/sysext/core/Tests/Functional/Console/CommandApplicationTest.php1new+53 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/Classes/Command/Lowlevel/LowlevelDisabledCommand.phpnew+42 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/Classes/Command/Lowlevel/LowlevelDisabledHiddenCommand.phpnew+42 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/Classes/Command/Lowlevel/LowlevelHiddenCommand.phpnew+37 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/Classes/ServiceProvider.phpnew+92 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/Configuration/Services.yaml+9 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_di/composer.json+2 −0
- typo3/sysext/core/Tests/Unit/Console/CommandApplicationTest.phpnew+101 −0
Review log 46
-
Alexander Stehlik uploaded patch set 1 06/02/26, 23:20
-
core-ci voted on patch set 1 V -1 06/02/26, 23:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102846
-
Oliver Klee commented on patch set 1 06/03/26, 07:30
We needCommandApplicationTest.php:30UnresolvedWe should use `#[Test]` for all these. -
Oliver Klee commented on patch set 1 06/03/26, 07:35
Reply
I have no idea what I was starting to say. 😕 -
Alexander Stehlik rebased onto patch set 2
V -110/02/26, 07:01 -
core-ci voted on patch set 2 V -1 10/02/26, 07:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109876