Review main Ready for review Quiet

94286[BUGFIX] Prevent loading of commands with incomplete Container

Alexander Stehlik CR 0 V -1 Hard +386 −1 updated 10/02/26, 07:17

Commit message

In some edge cases the CommandApplication will run into problems
when a lowlevel command can not be loaded.

When Symfony is not able to load a certain command it will try
to load all commands to show a helpful error message and suggest
alternative names. When this is done with an incomplete Dependency
Container, unexpected errors occur.

To prevent this, the checks if a full boot is needed are improved. When
a command is disabled or has a non matching name a full boot is
enforced to make sure all commands load without error.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/94286/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/94286/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 1

Issues 1

Files 9

Review log 46

  1. Alexander Stehlik uploaded patch set 1 06/02/26, 23:20

  2. core-ci voted on patch set 1 V -1 06/02/26, 23:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102846

  3. Oliver Klee commented on patch set 1 06/03/26, 07:30

    We need

    CommandApplicationTest.php:30 Unresolved

    We should use `#[Test]` for all these.
  4. Oliver Klee commented on patch set 1 06/03/26, 07:35

    Reply

    I have no idea what I was starting to say. 😕
  5. Alexander Stehlik rebased onto patch set 2 V -1 10/02/26, 07:01

  6. core-ci voted on patch set 2 V -1 10/02/26, 07:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109876