Review main Merged Breaking

94287[!!!][TASK] Remove array "password" workaround from redis cache

Christian Kuhn CR +2 V +2 Easy +2 −40 updated 06/03/26, 10:11

Commit message

Redis 6.0 introduced username/password authentication, which
the redis cache backend did not cover natively at first. As a
workaround the community passed the authentication tuple as an
array through the "password" option, which worked only because
the setter argument was not strictly typed.

Proper "username" and "password" options were added in v14 and
the array workaround was deprecated. The patch now removes it
b/w compat fallback.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 06/02/26, 23:30

  2. core-ci voted on patch set 1 V +1 06/02/26, 23:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102847

  3. Oliver Klee voted on patch set 1 CR +1 V +1 06/03/26, 07:31

  4. Christian Kuhn uploaded patch set 2 CR +1 V +1 06/03/26, 09:46

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 06/03/26, 09:49

  6. core-ci voted on patch set 2 V +1 06/03/26, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102878

  7. Oliver Klee voted on patch set 2 CR +1 V +1 06/03/26, 10:10

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 06/03/26, 10:11

  9. Christian Kuhn merged patch set 3 06/03/26, 10:11