94298[!!!][TASK] Set GeneralUtility->resolveBackPath() to private
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/core/Classes/Utility/GeneralUtility.php3+37 −32
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-109783-DeprecatedFunctionalityRemoved.rst+4 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+2 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+1 −0
Review log 910
-
Christian Kuhn uploaded patch set 1 06/03/26, 12:21
-
Oliver Klee voted on patch set 1 CR +1 06/03/26, 12:25
-
core-ci voted on patch set 1 V +1 06/03/26, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102892
-
Mathias Brodala commented on patch set 1 06/03/26, 12:37
-
Oliver Klee voted on patch set 1 V +1 06/03/26, 12:43
-
Christian Kuhn commented on patch set 1 06/03/26, 12:57
GeneralUtility.php:2175Replyclosure does not really make it less ugly. i think going with private and having it directly below the caller with a message is fine for now - and i think we'll have to think about sanitizeLocalUrl() consumers soon, anyway. i hope it is fine with you to keep it this way for now. -
Stefan Bürk voted on patch set 1 CR +1 V +1 06/03/26, 13:18
-
Christian Kuhn commented on patch set 1 06/03/26, 13:31
GeneralUtility.php:2175Replyplus: closure wouldn't be testable at all, and i didn't wanted to loose the tests right now. -
Christian Kuhn voted on patch set 1 CR +2 V +2 06/03/26, 13:31
-
Christian Kuhn merged patch set 2 06/03/26, 13:31
GeneralUtility.php:2175