Review main Merged Breaking

94298[!!!][TASK] Set GeneralUtility->resolveBackPath() to private

Christian Kuhn CR +2 V +2 Normal +44 −33 updated 06/03/26, 13:31

Commit message

Phasing out GeneralUtility::resolveBackPath() is quite a journey:
The method is now declared private and moved below it's sole
consumer sanitizeLocalUrl(), which needs a refactoring on its own.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 910

  1. Christian Kuhn uploaded patch set 1 06/03/26, 12:21

  2. Oliver Klee voted on patch set 1 CR +1 06/03/26, 12:25

  3. core-ci voted on patch set 1 V +1 06/03/26, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102892

  4. Mathias Brodala commented on patch set 1 06/03/26, 12:37

    GeneralUtility.php:2175

    How about inlining this code directly in santizeLocalUrl, if necessary as closure? Than it is impossible to accidentally add another caller for this.
  5. Oliver Klee voted on patch set 1 V +1 06/03/26, 12:43

  6. Christian Kuhn commented on patch set 1 06/03/26, 12:57

    GeneralUtility.php:2175 Reply

    closure does not really make it less ugly. i think going with private and having it directly below the caller with a message is fine for now - and i think we'll have to think about sanitizeLocalUrl() consumers soon, anyway. i hope it is fine with you to keep it this way for now.
  7. Stefan Bürk voted on patch set 1 CR +1 V +1 06/03/26, 13:18

  8. Christian Kuhn commented on patch set 1 06/03/26, 13:31

    GeneralUtility.php:2175 Reply

    plus: closure wouldn't be testable at all, and i didn't wanted to loose the tests right now.
  9. Christian Kuhn voted on patch set 1 CR +2 V +2 06/03/26, 13:31

  10. Christian Kuhn merged patch set 2 06/03/26, 13:31