Review main Merged

94300[BUGFIX] Gracefully handle missing packages in TranslationDomainMapper

Achim Fritz CR +2 V +2 Easy +13 −1 updated 06/12/26, 10:31

Commit message

The `TranslationDomainMapper::resolveToLegacyFile()` method calls
`findLabelResourcesInPackage()` which throws an
`\InvalidArgumentException` when the referenced extension package
does not exist. This can happen when translation domains reference
uninstalled or non-existent extensions.

Instead of letting the exception bubble up, the domain string is
now returned as-is, which is consistent with the existing fallback
behavior for unknown domains.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 610

  1. Achim Fritz uploaded patch set 1 06/03/26, 13:14

  2. core-ci voted on patch set 1 V -1 06/03/26, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102901

  3. Josua Vogel uploaded patch set 2 V -1 06/12/26, 09:44

  4. Josua Vogel updated the commit message in patch set 3 06/12/26, 09:49

  5. core-ci voted on patch set 2 V +1 06/12/26, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103439

  6. core-ci voted on patch set 3 V -1 06/12/26, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103440

  7. core-ci voted on patch set 3 V +1 06/12/26, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103440

  8. Josua Vogel voted on patch set 3 CR +1 V +1 06/12/26, 10:29

  9. Benni Mack voted on patch set 3 CR +2 V +2 06/12/26, 10:31

  10. Benni Mack merged patch set 4 06/12/26, 10:31