Review main Merged Breaking

94310[!!!][TASK] Throw on extensions with incomplete composer.json

Christian Kuhn CR +2 V +2 Hard +63 −280 updated 06/18/26, 23:10

Commit message

With #108345 the ext_emconf.php file was deprecated as a source
of package metadata. Extensions shipping an ext_emconf.php whose
composer.json did not declare the extension version and the
"providesPackages" definition were patched up from ext_emconf.php
and emitted a deprecation message.

The patch removes that fallback and clarifies some details by
docs amendments and new comments. The v14 .rst change will have
a dedicated backport patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 3

Files 8

Review log 2634

Show 79 earlier messages
  1. Christian Kuhn uploaded patch set 1 06/03/26, 16:51

  2. Oliver Klee commented on patch set 1 06/03/26, 16:59

    PackageManager.php:933

    Is there a "not" missing? ```suggestion // Extensions not shipping an ext_emconf.php must declare the required metadata in composer.json ```
  3. core-ci voted on patch set 1 V -1 06/03/26, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102919

  4. Christian Kuhn uploaded patch set 2 V -1 06/04/26, 00:20

  5. Christian Kuhn voted on patch set 2 CR -1 06/04/26, 00:21

  6. Christian Kuhn commented on patch set 2 06/04/26, 00:25

    PackageManager.php:933 Reply

    i'll rephrase.
  7. core-ci voted on patch set 2 V +1 06/04/26, 00:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102925

  8. Christian Kuhn uploaded patch set 3 CR -1 V +1 06/04/26, 00:49

  9. Christian Kuhn commented on patch set 3 CR -1 06/04/26, 00:51

    coordinating details with helmut.
  1. core-ci voted on patch set 3 V -1 06/04/26, 00:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102926

  2. Christian Kuhn uploaded patch set 4 CR -1 V -1 06/04/26, 10:32

  3. core-ci voted on patch set 4 V -1 06/04/26, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102944

  4. Christian Kuhn uploaded patch set 5 V -1 06/04/26, 11:04

  5. core-ci voted on patch set 5 V +1 06/04/26, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102945

  6. Oliver Klee commented on patch set 5 V +1 06/04/26, 12:01

    I've added some thoughts on making the code more clear.

    Package.php:153

    Not blocking: To make the intention behind the code more clear, we should move the `$title = $description;` into an `else` branch.

    Package.php:158

    This also could move to an else branch below.
  7. Christian Kuhn commented on patch set 5 06/04/26, 12:07

    Package.php:153 Reply

    matter of taste, but yeah, it reads better with [] being gone.

    Package.php:158 Reply

    ok. follows the above idea.
  8. Christian Kuhn uploaded patch set 6 V +1 06/04/26, 12:07

  9. core-ci voted on patch set 6 V +1 06/04/26, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102950

  10. Oliver Klee voted on patch set 6 V +1 06/04/26, 12:38

  11. Oliver Klee voted on patch set 6 CR +1 06/04/26, 12:39

  12. Helmut Hummel uploaded patch set 7 CR +1 V +1 06/04/26, 21:22

  13. core-ci voted on patch set 7 V -1 06/04/26, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102984

  14. Helmut Hummel uploaded patch set 8 V -1 06/08/26, 10:46

  15. core-ci voted on patch set 8 V +1 06/08/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103120

  16. Oliver Klee voted on patch set 8 V +1 06/08/26, 11:19

  17. Oliver Klee wrote 06/08/26, 11:42

    Removed reviewer Oliver Klee with the following votes: * Verified+1 by Oliver Klee
  18. Christian Kuhn voted on patch set 8 CR +1 V +1 06/09/26, 21:09

  19. Helmut Hummel voted on patch set 8 CR +1 V +1 06/10/26, 06:17

  20. Stefan Bürk voted on patch set 8 CR +1 V +1 06/10/26, 08:23

  21. Christian Kuhn voted on patch set 8 CR +2 V +2 06/10/26, 09:17

  22. Christian Kuhn merged patch set 9 06/10/26, 09:17

  23. Benjamin Franzke commented on patch set 9 06/10/26, 10:25

    May there be something off that will only be triggered in the nightlies? I just triggered a nightly on another change and there is following error printed: https://git.typo3.org/typo3/CI/cms/-/jobs/5688958 ``` 1) TYPO3\CMS\Form\Tests\Functional\Storage\ExtensionStorageAdapterFunctionalTest::readThrowsExceptionWhenFormDefinitionHasInvalidFileExtension with data set #0 ('EXT:form_storage_tests/Resour...m.yaml', null) TYPO3\CMS\Core\Package\Exception\InvalidPackageManifestException: The composer.json of extension "form_storage_tests" must declare the extension version and the "providesPackages" definition in the "extra/typo3/cms" section. See https://docs.typo3.org/permalink/changelog:deprecation-108345-1774126701@15.0 for details. /builds/typo3/CI/cms/typo3/sysext/core/Classes/Package/PackageManager.php:943 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Package/Package.php:113 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/PackageCollection.php:92 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Testbase.php:655 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Functional/FunctionalTestCase.php:422 /builds/typo3/CI/cms/typo3/sysext/form/Tests/Functional/Storage/ExtensionStorageAdapterFunctionalTest.php:39 /builds/typo3/CI/cms/bin/phpunit:122 2) TYPO3\CMS\Form\Tests\Functional\Storage\ExtensionStorageAdapterFunctionalTest::readThrowsExceptionWhenFormDefinitionHasInvalidFileExtension with data set #1 ('EXT:form_storage_tests/Resour...e.yaml', 1531160649) ArgumentCountError: Too few arguments to function TYPO3\CMS\Core\Schema\TcaSchemaFactory::__construct(), 0 passed in /builds/typo3/CI/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 2489 and exactly 3 expected /builds/typo3/CI/cms/typo3/sysext/core/Classes/Schema/TcaSchemaFactory.php:42 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2489 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Database/Query/Restriction/DeletedRestriction.php:36 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2489 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Database/Query/Restriction/AbstractRestrictionContainer.php:109 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Database/Query/Restriction/DefaultRestrictionContainer.php:43 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2489 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Database/Connection.php:130 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Testbase.php:912 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Testbase.php:875 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Testbase.php:798 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Functional/FunctionalTestCase.php:501 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Functional/FunctionalTestCase.php:312 /builds/typo3/CI/cms/typo3/sysext/form/Tests/Functional/Storage/ExtensionStorageAdapterFunctionalTest.php:39 3) TYPO3\CMS\Form\Tests\Functional\Storage\ExtensionStorageAdapterFunctionalTest::readThrowsExceptionWhenFormDefinitionHasInvalidFileExtension with data set #2 ('EXT:form_storage_tests/Resour...e.yaml', 1531160649) ArgumentCountError: Too few arguments to function TYPO3\CMS\Core\Schema\TcaSchemaFactory::__construct(), 0 passed in /builds/typo3/CI/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 2489 and exactly 3 expected /builds/typo3/CI/cms/typo3/sysext/core/Classes/Schema/TcaSchemaFactory.php:42 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2489 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Database/Query/Restriction/DeletedRestriction.php:36 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2489 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Database/Query/Restriction/AbstractRestrictionContainer.php:109 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Database/Query/Restriction/DefaultRestrictionContainer.php:43 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2489 /builds/typo3/CI/cms/typo3/sysext/core/Classes/Database/Connection.php:130 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Testbase.php:912 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Testbase.php:875 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Testbase.php:798 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Functional/FunctionalTestCase.php:501 /builds/typo3/CI/cms/vendor/typo3/testing-framework/Classes/Core/Functional/FunctionalTestCase.php:312 /builds/typo3/CI/cms/typo3/sysext/form/Tests/Functional/Storage/ExtensionStorageAdapterFunctionalTest.php:39 -- 2 tests triggered 2 PHP warnings: 1) /builds/typo3/CI/cms/typo3/sysext/core/Classes/Package/PackageManager.php:743 Undefined array key "packages" Triggered by: * TYPO3\CMS\Form\Tests\Functional\Storage\ExtensionStorageAdapterFunctionalTest::readThrowsExceptionWhenFormDefinitionHasInvalidFileExtension#1 /builds/typo3/CI/cms/typo3/sysext/form/Tests/Functional/Storage/ExtensionStorageAdapterFunctionalTest.php:53 * TYPO3\CMS\Form\Tests\Functional\Storage\ExtensionStorageAdapterFunctionalTest::readThrowsExceptionWhenFormDefinitionHasInvalidFileExtension#2 /builds/typo3/CI/cms/typo3/sysext/form/Tests/Functional/Storage/ExtensionStorageAdapterFunctionalTest.php:53 2) /builds/typo3/CI/cms/typo3/sysext/core/Classes/Package/PackageManager.php:768 foreach() argument must be of type array|object, null given Triggered by: * TYPO3\CMS\Form\Tests\Functional\Storage\ExtensionStorageAdapterFunctionalTest::readThrowsExceptionWhenFormDefinitionHasInvalidFileExtension#1 /builds/typo3/CI/cms/typo3/sysext/form/Tests/Functional/Storage/ExtensionStorageAdapterFunctionalTest.php:53 * TYPO3\CMS\Form\Tests\Functional\Storage\ExtensionStorageAdapterFunctionalTest::readThrowsExceptionWhenFormDefinitionHasInvalidFileExtension#2 /builds/typo3/CI/cms/typo3/sysext/form/Tests/Functional/Storage/ExtensionStorageAdapterFunctionalTest.php:53 ERRORS! Tests: 1222, Assertions: 4092, Errors: 3, Warnings: 2. ```
  24. Benjamin Franzke commented on patch set 9 06/10/26, 10:28

    Reply

    Well, I see, it is not just nightlies, but because of a conflict with a security patch: > 94433: [SECURITY] Properly evaluate .form.yaml file extension | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94433 This one introduced a new composer.json file that is not yet adapted to the newly enforced rules of this patch.
  25. Benjamin Franzke commented on patch set 9 06/10/26, 10:41

    Reply

    Resolving here, pushed a fix: > 94457: [TASK] Adapt form_storage_tests to #109993 requirements | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94457