94312[TASK] Revert "[TASK] Remove FilePersistenceSlot and related dead code in ext:form"
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Stefan Bürk +1
- Christian Kuhn +1
- Josua Vogel +1
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Stefan Bürk +1
- Christian Kuhn +1
- Josua Vogel +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/form/Classes/Hooks/ImportExportHook.phpnew+38 −0
- typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.php+37 −5
- typo3/sysext/form/Classes/Slot/FilePersistenceSlot.phpnew+183 −0
- typo3/sysext/form/Classes/Slot/FormDefinitionPersistenceException.phpnew+23 −0
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/YamlSourceTest.php+7 −5
- typo3/sysext/form/ext_localconf.php+7 −0
Review log 1113
-
Benjamin Franzke uploaded patch set 1 06/04/26, 09:55
-
Benjamin Franzke uploaded patch set 2 06/04/26, 10:00
-
core-ci voted on patch set 1 V +1 06/04/26, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102941
-
core-ci voted on patch set 2 V +1 06/04/26, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102943
-
Oliver Klee voted on patch set 2 CR +1 V +1 06/04/26, 10:12
-
Christian Kuhn commented on patch set 2 06/04/26, 14:14
josua pinged me on the situation as well, and the upgrade wizard is currently broken due to another removal it relies on (which we'll probably solve differently). i'll coordinate a bit and will come back to this patch tomorrow, latest. -
Josua Vogel commented on patch set 2 CR +1 V +1 06/04/26, 16:07
The revert is fine for me :) Thank you very much, and I apologize for the extra work -
Oliver Hader voted on patch set 2 CR +1 V +1 06/04/26, 16:47
-
Christian Kuhn voted on patch set 2 CR +1 V +1 06/04/26, 16:48
-
Stefan Bürk voted on patch set 2 CR +1 V +1 06/04/26, 16:50
-
Benjamin Franzke voted on patch set 2 CR +2 V +2 06/05/26, 07:33
-
Benjamin Franzke commented on patch set 2 06/05/26, 07:34
Thx folks! -
Benjamin Franzke merged patch set 3 06/05/26, 07:34