Review main Merged

94312[TASK] Revert "[TASK] Remove FilePersistenceSlot and related dead code in ext:form"

Benjamin Franzke CR +2 V +2 Hard +295 −10 updated 06/05/26, 07:34

Commit message

This reverts commit a1f9759e04f428f71a9a73053fc275e0011b1188.

The file persistence slot and related code is required as long
as `FileFormsToDatabaseUpgradeWizard` is still available.

The migration wizard will offer to migrate uploaded `.form.yaml` files
to database entries and therefore this file extension still needs
protection. Otherwise forms may be generated by editors, without having
permission to do so (e.g. in case the migration wizard is run
automatically during deployments).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Josua Vogel +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Josua Vogel +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1113

  1. Benjamin Franzke uploaded patch set 1 06/04/26, 09:55

  2. Benjamin Franzke uploaded patch set 2 06/04/26, 10:00

  3. core-ci voted on patch set 1 V +1 06/04/26, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102941

  4. core-ci voted on patch set 2 V +1 06/04/26, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102943

  5. Oliver Klee voted on patch set 2 CR +1 V +1 06/04/26, 10:12

  6. Christian Kuhn commented on patch set 2 06/04/26, 14:14

    josua pinged me on the situation as well, and the upgrade wizard is currently broken due to another removal it relies on (which we'll probably solve differently). i'll coordinate a bit and will come back to this patch tomorrow, latest.
  7. Josua Vogel commented on patch set 2 CR +1 V +1 06/04/26, 16:07

    The revert is fine for me :) Thank you very much, and I apologize for the extra work
  8. Oliver Hader voted on patch set 2 CR +1 V +1 06/04/26, 16:47

  9. Christian Kuhn voted on patch set 2 CR +1 V +1 06/04/26, 16:48

  10. Stefan Bürk voted on patch set 2 CR +1 V +1 06/04/26, 16:50

  11. Benjamin Franzke voted on patch set 2 CR +2 V +2 06/05/26, 07:33

  12. Benjamin Franzke commented on patch set 2 06/05/26, 07:34

    Thx folks!
  13. Benjamin Franzke merged patch set 3 06/05/26, 07:34