Review 14.3 Merged

94327[TASK] Free EXT:styleguide from hard requirements form/fsc/seo/search

Garvin Hicking CR +2 V +2 Easy +9 −7 updated 06/04/26, 18:56

Commit message

For dev setups that want to use EXT:styleguide to showcase features
in a staging or even production deployment, there should be no
hardcoded requirements to optional TYPO3 packages that are not
necessarily needed.

This patch makes them optional, which should gracefully degrade
to the requirements. If the frontend rendering is wanted,
EXT:fluid_styled_content will usually already be a fulfilled
dependency by other extensions (like a sitepackage).

The main reason that EXT:styleguide shipped these dependencies
seemed to only stem from the Site settings, carrying them as
`dependencies` instead of `optionalDependencies`.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Garvin Hicking commented on patch set 1 06/04/26, 18:43

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/styleguide/composer.json
  2. Garvin Hicking commented on patch set 2 06/04/26, 18:44

    Published edit on patch set 1.
  3. Garvin Hicking commented on patch set 3 06/04/26, 18:45

    Published edit on patch set 2.
  4. Garvin Hicking marked it ready for review 06/04/26, 18:45

  5. core-ci voted on patch set 3 V +1 06/04/26, 18:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102980

  6. Garvin Hicking voted on patch set 3 CR +2 V +2 06/04/26, 18:56

  7. Garvin Hicking merged patch set 4 06/04/26, 18:56