Review 14.3 Merged

94335[TASK] Harden toggleRecordVisibilityAction access checks

Oliver Hader CR +2 V +2 Easy +15 −1 updated 06/05/26, 14:26

Commit message

Adds explicit backend user permission checks to the record
visibility toggle endpoint before delegating to DataHandler:

- Verify tables_modify access for the target table
- Fetch record pid to perform readPageAccess validation
- Skip page access check for root-level records whose
  schema opts out of root-level restrictions

Note: This change is not classified as a security vulnerability,
since DataHandler already enforces authorization on the write
path, and the endpoint exposes no confidential data within
TYPO3's security model.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Oliver Hader uploaded patch set 1 06/05/26, 08:55

  2. core-ci voted on patch set 1 V +1 06/05/26, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103022

  3. Oliver Hader updated the commit message in patch set 2 V +1 06/05/26, 09:11

  4. core-ci voted on patch set 2 V +1 06/05/26, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103024

  5. Oliver Hader voted on patch set 2 CR +2 V +2 06/05/26, 14:25

  6. Oliver Hader merged patch set 3 06/05/26, 14:26