94336[BUGFIX] Ensure FileFormsToDatabaseUpgradeWizard works without FileMountStorageAdapter
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/form/Classes/Hooks/ImportExportHook.php+2 −1
- typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.php+4 −1
- typo3/sysext/form/Classes/Slot/FilePersistenceSlot.php+2 −1
- typo3/sysext/form/Classes/Slot/FormDefinitionPersistenceException.php+1 −0
- typo3/sysext/form/Classes/Upgrades/FileFormsToDatabaseUpgradeWizard.php+302 −14
Review log 1521
-
Josua Vogel uploaded patch set 1 06/05/26, 11:20
-
Josua Vogel marked it work in progress 06/05/26, 11:20
-
core-ci voted on patch set 1 V -1 06/05/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103025
-
Josua Vogel uploaded patch set 2
V -106/05/26, 11:29 -
Josua Vogel marked it ready for review 06/05/26, 11:29
-
core-ci voted on patch set 2 V -1 06/05/26, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103026
-
Christian Kuhn commented on patch set 2 06/05/26, 11:44
thank you! do you think we could also mark the files and snippets that have been re-established with https://review.typo3.org/c/Packages/TYPO3.CMS/+/94312 with some additional information that they can be removed when this upgrade wizard is removed in v16? this should simplify the removal patch at this point in time when we cross link using some comments. -
Josua Vogel rebased onto patch set 3
V -106/05/26, 11:46 -
core-ci voted on patch set 3 V -1 06/05/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103028
-
Josua Vogel uploaded patch set 4
V -106/05/26, 12:01 -
core-ci voted on patch set 4 V +1 06/05/26, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103029
-
Josua Vogel uploaded patch set 5
V +106/05/26, 12:10 -
Josua Vogel commented on patch set 5 06/05/26, 12:10
Reply
Done -
core-ci voted on patch set 5 V +1 06/05/26, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103030
-
Stefan Bürk voted on patch set 5 CR +1 06/11/26, 08:47
-
Stefan Bürk updated the commit message in patch set 6
CR +1V +106/11/26, 08:48 -
Stefan Bürk voted on patch set 6 CR +1 06/11/26, 08:48
-
core-ci voted on patch set 6 V +1 06/11/26, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103381
-
Christian Kuhn voted on patch set 6 CR +2 V +2 06/11/26, 09:20
-
Christian Kuhn merged patch set 7 06/11/26, 09:20
-
Stefan Bürk commented on patch set 7 06/11/26, 09:28
post +1 verified ....