Review main Merged

94336[BUGFIX] Ensure FileFormsToDatabaseUpgradeWizard works without FileMountStorageAdapter

Josua Vogel CR +2 V +2 Hard +311 −17 updated 06/11/26, 09:28

Commit message

The FileMountStorageAdapter was removed, because form
definitions inside FAL aren´t supported anymore. The
FileFormsToDatabaseUpgradeWizard relied on it via
FormTransferService::listSourceForms(), ::readForm()
and ::deleteForm() with the 'filemount' type identifier.

The wizard now directly uses the FAL API (ResourceFactory,
StorageRepository, YamlSource) to read, list and delete YAML
form definitions from the paths configured in
`persistenceManager.allowedFileMounts`. This mirrors the logic
that was previously encapsulated in FileMountStorageAdapter.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 1521

  1. Josua Vogel uploaded patch set 1 06/05/26, 11:20

  2. Josua Vogel marked it work in progress 06/05/26, 11:20

  3. core-ci voted on patch set 1 V -1 06/05/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103025

  4. Josua Vogel uploaded patch set 2 V -1 06/05/26, 11:29

  5. Josua Vogel marked it ready for review 06/05/26, 11:29

  6. core-ci voted on patch set 2 V -1 06/05/26, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103026

  7. Christian Kuhn commented on patch set 2 06/05/26, 11:44

    thank you! do you think we could also mark the files and snippets that have been re-established with https://review.typo3.org/c/Packages/TYPO3.CMS/+/94312 with some additional information that they can be removed when this upgrade wizard is removed in v16? this should simplify the removal patch at this point in time when we cross link using some comments.
  8. Josua Vogel rebased onto patch set 3 V -1 06/05/26, 11:46

  9. core-ci voted on patch set 3 V -1 06/05/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103028

  10. Josua Vogel uploaded patch set 4 V -1 06/05/26, 12:01

  11. core-ci voted on patch set 4 V +1 06/05/26, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103029

  12. Josua Vogel uploaded patch set 5 V +1 06/05/26, 12:10

  13. Josua Vogel commented on patch set 5 06/05/26, 12:10

    Reply

    Done
  14. core-ci voted on patch set 5 V +1 06/05/26, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103030

  15. Stefan Bürk voted on patch set 5 CR +1 06/11/26, 08:47

  16. Stefan Bürk updated the commit message in patch set 6 CR +1 V +1 06/11/26, 08:48

  17. Stefan Bürk voted on patch set 6 CR +1 06/11/26, 08:48

  18. core-ci voted on patch set 6 V +1 06/11/26, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103381

  19. Christian Kuhn voted on patch set 6 CR +2 V +2 06/11/26, 09:20

  20. Christian Kuhn merged patch set 7 06/11/26, 09:20

  21. Stefan Bürk commented on patch set 7 06/11/26, 09:28

    post +1 verified ....