Review main Merged

94340[BUGFIX] Use translation domain in EXT:linkvalidator mail template

Maike Kiebele CR +2 V +2 Normal +26 −26 updated 06/09/26, 15:06

Commit message

This patch adjusts the translation domains in EXT:linkvalidator
so that the new syntax is used and the output in the email template
works again.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 2130

Show 35 earlier messages
  1. Maike Kiebele uploaded patch set 1 06/05/26, 13:45

  2. core-ci voted on patch set 1 V +1 06/05/26, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103036

  3. Maike Kiebele updated the commit message in patch set 2 V +1 06/05/26, 13:57

  4. Maike Kiebele updated the commit message in patch set 3 06/05/26, 14:01

  5. core-ci voted on patch set 2 V +1 06/05/26, 14:06 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103038

  1. core-ci voted on patch set 3 V +1 06/05/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103039

  2. Maike Kiebele uploaded patch set 4 V +1 06/05/26, 14:22

  3. core-ci voted on patch set 4 V +1 06/05/26, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103040

  4. Garvin Hicking uploaded patch set 5 V +1 06/05/26, 18:04

  5. Garvin Hicking voted on patch set 5 CR +1 V +1 06/05/26, 18:07

  6. core-ci voted on patch set 5 V +1 06/05/26, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103046

  7. Josua Vogel voted on patch set 5 CR +1 V +1 06/05/26, 18:17

  8. Christian Kuhn commented on patch set 5 CR -1 06/05/26, 20:53

    ValidatorTask.fluid.txt:2

    domain="linkvalidator.db"" the double quotes need to vanish. also below.
  9. Garvin Hicking commented on patch set 6 CR +1 V +1 06/05/26, 21:40

    Published edit on patch set 5.
  10. Garvin Hicking commented on patch set 7 06/05/26, 21:41

    Published edit on patch set 6.
  11. core-ci voted on patch set 6 V +1 06/05/26, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103050

  12. core-ci voted on patch set 7 V +1 06/05/26, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103051

  13. Christian Kuhn commented on patch set 7 06/05/26, 22:36

    ValidatorTask.fluid.txt:2 Reply

    Done
  14. Christian Kuhn commented on patch set 7 CR +1 V +1 06/05/26, 22:44

    ValidatorTask.fluid.txt:13

    note this key does not exist in the .xlf files, so this renders empty. Not a regression of this patch, we can go ahead and merge it as is, but the dead reference should then probably be fixed (or removed) with another patch. The html variant uses tasks.email.listing.pageExplanation and tasks.email.listing.hoverExpalantion instead, aligning the txt template with those might be the way to go.
  15. Josua Vogel commented on patch set 7 06/08/26, 06:27

    ValidatorTask.fluid.txt:13 Reply

    I couldn't find any occurrence of the key tasks.email.listing.notes. It was added to the template as part of ticket 29342, but the key was already missing in that change. I think it can be removed. Instead, we should add tasks.email.listing.pageExplanation above the table. The key tasks.email.listing.hoverExplanation describes a functionality that is not supported in plain email format.
  16. Maike Kiebele uploaded patch set 8 CR +1 V +1 06/08/26, 08:29

  17. core-ci voted on patch set 8 V +1 06/08/26, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103111

  18. Josua Vogel commented on patch set 8 06/08/26, 08:50

    ValidatorTask.fluid.txt:13

    @maike.kiebele@gmail.com I would put the pageExplanation above explanation, as explanation contains the "table" header
  19. Maike Kiebele uploaded patch set 9 V +1 06/08/26, 08:52

  20. core-ci voted on patch set 9 V +1 06/08/26, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103112

  21. Josua Vogel commented on patch set 9 CR +1 V +1 06/08/26, 09:05

    Thx @maike.kiebele@gmail.com !

    ValidatorTask.fluid.txt:13 Reply

    Done

    ValidatorTask.fluid.txt:13 Reply

    Done
  22. Garvin Hicking commented on patch set 9 CR +1 V +1 06/08/26, 19:53

    Thank you!
  23. Garvin Hicking commented on patch set 9 06/08/26, 19:54

    (note, do not merge this today/tomorrow yet @georg.ringer@gmail.com ;))
  24. Garvin Hicking commented on patch set 9 CR +2 V +2 06/09/26, 15:06

    Reply

    Done
  25. Garvin Hicking merged patch set 10 06/09/26, 15:06