94341[TASK] Extract form translation key chain building into dedicated class
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/form/Classes/Domain/Translation/FormTranslationKeyChainBuilder.php10new+272 −0
- typo3/sysext/form/Classes/Service/TranslationService.php+92 −63
- typo3/sysext/form/Tests/Functional/Service/TranslationServiceTest.php+3 −1
- typo3/sysext/form/Tests/Unit/Domain/Translation/FormTranslationKeyChainBuilderTest.phpnew+310 −0
Review log 1317
-
Josua Vogel uploaded patch set 1 06/05/26, 15:52
-
core-ci voted on patch set 1 V +1 06/05/26, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103043
-
Oliver Klee voted on patch set 1 V +1 06/05/26, 20:22
-
Oliver Klee commented on patch set 1 06/05/26, 20:31
FormTranslationKeyChainBuilder.php:68All these `$translationFiles` parameters should get a PHPDoc type annotation `@param array<string> $translationFiles`.FormTranslationKeyChainBuilder.php:88Also, if I read this correctly, we have exactly the same code multiple times. We should move this to a central place instead of duplicating it.FormTranslationKeyChainBuilder.php:97All these methods should get a return annotation `@return list<string>`.FormTranslationKeyChainBuilder.php:137Nitpick: Can we make all these `!empty` checks more specific, i.e., either `is_string` or `!==`? -
Josua Vogel uploaded patch set 2
V +106/07/26, 15:51 -
core-ci voted on patch set 2 V +1 06/07/26, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103085
-
Josua Vogel commented on patch set 2 06/07/26, 16:04
FormTranslationKeyChainBuilder.php:44ReplyDoneFormTranslationKeyChainBuilder.php:68ReplyDoneFormTranslationKeyChainBuilder.php:88ReplyDoneFormTranslationKeyChainBuilder.php:97ReplyDoneFormTranslationKeyChainBuilder.php:137ReplyDone -
Oliver Klee voted on patch set 2 V +1 06/07/26, 21:00
-
Josua Vogel updated the commit message in patch set 3
V +106/08/26, 06:06 -
core-ci voted on patch set 3 V +1 06/08/26, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103109
-
Oliver Klee commented on patch set 3 CR +1 V +1 06/09/26, 14:16
Beautiful! -
Christian Kuhn uploaded patch set 4
CR +1V +106/09/26, 21:45 -
Christian Kuhn commented on patch set 4 CR +1 V +1 06/09/26, 21:45
filling a test gap and minor test adaptions, only. -
core-ci voted on patch set 4 V +1 06/09/26, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103248
-
Oliver Klee voted on patch set 4 CR +1 V +1 06/09/26, 22:13
-
Christian Kuhn voted on patch set 4 CR +2 V +2 06/09/26, 22:29
-
Christian Kuhn merged patch set 5 06/09/26, 22:29
FormTranslationKeyChainBuilder.php:44