94342[TASK] Replace SingletonInterface with Symfony DI in EXT:form TranslationService
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 911
-
Josua Vogel uploaded patch set 1 06/05/26, 16:02
-
core-ci voted on patch set 1 V +1 06/05/26, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103044
-
Oliver Klee voted on patch set 1 CR +1 V +1 06/05/26, 16:38
-
Garvin Hicking voted on patch set 1 CR +1 V +1 06/05/26, 18:09
-
Christian Kuhn commented on patch set 1 06/05/26, 20:19
note this one is on top of https://review.typo3.org/c/Packages/TYPO3.CMS/+/94341/, so we may want to review that one, first. -
Christian Kuhn uploaded patch set 2
CR +1V +106/05/26, 22:54 -
Christian Kuhn commented on patch set 2 06/05/26, 22:55
Reply
i broke this chain now to make this patch standalone.UploadedFileReferenceConverter.php:97as "leaf" class, this class should *not* use inject* methods (the only legit use for inject* method are abstract classes to not pollute __costruct() of leaf's). since more existing stuff in this class violates this (and potentially others in this chain, too), i'm fine with not changing the strategy here, but we should get this right with another patch. -
core-ci voted on patch set 2 V +1 06/05/26, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103053
-
Garvin Hicking voted on patch set 2 CR +1 V +1 06/05/26, 23:07
-
Christian Kuhn voted on patch set 2 CR +2 V +2 06/05/26, 23:16
-
Christian Kuhn merged patch set 3 06/05/26, 23:17